From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Adam Kropelin <akropel1@rochester.rr.com>
Cc: Frank Davis <fdavis@si.rr.com>,
linux-kernel@vger.kernel.org, davej@suse.de,
Brian Gerst <bgerst@didntduck.org>
Subject: Re: 2.5.8-dj1 : arch/i386/kernel/smpboot.c error
Date: Wed, 17 Apr 2002 13:49:18 -0700 [thread overview]
Message-ID: <1829430000.1019076558@flay> (raw)
In-Reply-To: <20020417191718.GA8660@www.kroptech.com>
>> I wonder if we can play the same trick we've played before ....
>> haven't tested the appended, but maybe it, or something like it
>> will work without the ifdef's?
>
> IMHO, this sort of trickery in the name of improving readability
> is misguided. To me, anyway, the #ifdef's are much easer to read than
> magic name-changing macros buried in a header somewhere.
Well, except that you can take that abstraction inside your head, and
not worry about it when reading the mainline code. I don't really care
one way or the other, at least io.h is readable now ;-)
M.
next prev parent reply other threads:[~2002-04-17 19:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-16 2:19 2.5.8-dj1 : arch/i386/kernel/smpboot.c error Frank Davis
2002-04-17 2:47 ` Adam Kropelin
2002-04-17 4:59 ` Martin J. Bligh
2002-04-17 12:30 ` Adam Kropelin
2002-04-17 12:40 ` Adam Kropelin
2002-04-17 15:28 ` Martin J. Bligh
2002-04-17 19:17 ` Adam Kropelin
2002-04-17 19:31 ` Rick Stevens
2002-04-17 20:53 ` Martin J. Bligh
2002-04-17 20:40 ` Adam Kropelin
2002-04-17 21:17 ` Rick Stevens
2002-04-17 21:49 ` Adam Kropelin
2002-04-17 22:06 ` J.A. Magallon
2002-04-18 0:34 ` Martin J. Bligh
2002-04-18 2:16 ` Stevie O
2002-04-17 20:49 ` Martin J. Bligh [this message]
2002-04-17 22:56 ` Stevie O
2002-04-18 0:29 ` Martin J. Bligh
2002-04-21 13:37 ` [PATCH] " Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1829430000.1019076558@flay \
--to=martin.bligh@us.ibm.com \
--cc=akropel1@rochester.rr.com \
--cc=bgerst@didntduck.org \
--cc=davej@suse.de \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox