From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751588AbdCCH3j convert rfc822-to-8bit (ORCPT ); Fri, 3 Mar 2017 02:29:39 -0500 Received: from gloria.sntech.de ([95.129.55.99]:38068 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbdCCHOV (ORCPT ); Fri, 3 Mar 2017 02:14:21 -0500 From: Heiko Stuebner To: Rob Herring Cc: Meng Dongyang , mark.rutland@arm.com, geert+renesas@glider.be, yoshihiro.shimoda.uh@renesas.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, kishon@ti.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, huangtao@rock-chips.com, kever.yang@rock-chips.com, william.wu@rock-chips.com, frank.wang@rock-chips.com Subject: Re: [PATCH v2 2/3] Documentation: bindings: add DT documentation for u2phy and u2phy grf Date: Fri, 03 Mar 2017 08:13:35 +0100 Message-ID: <1836183.aHLuUaOhIY@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <20170303062156.cofjy6sndxz3gch5@rob-hp-laptop> References: <1488440945-27291-1-git-send-email-daniel.meng@rock-chips.com> <1488440945-27291-3-git-send-email-daniel.meng@rock-chips.com> <20170303062156.cofjy6sndxz3gch5@rob-hp-laptop> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 3. März 2017, 00:21:56 CET schrieb Rob Herring: > On Thu, Mar 02, 2017 at 03:49:04PM +0800, Meng Dongyang wrote: > > Due to the u2phy registers are separated from general grf, we need to > > add u2phy grf node and place u2phy node in it. So this patch add u2phy > > grf node. > > Similar comment on the subject. > > > Changes in v2: > > - add u2phy grf specification > > > > Signed-off-by: Meng Dongyang > > --- > > > > Documentation/devicetree/bindings/soc/rockchip/grf.txt | 15 > > +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > b/Documentation/devicetree/bindings/soc/rockchip/grf.txt index > > 013e71a..6ac23f9 100644 > > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > @@ -7,6 +7,9 @@ From RK3368 SoCs, the GRF is divided into two sections, > > > > - GRF, used for general non-secure system, > > - PMUGRF, used for always on system > > > > +On RK3328 SoCs, the GRF is divided into three sections, > > +except GRF and PMUGRF, add a section for USB2PHYGRF, > > + > > > > Required Properties: > > > > - compatible: GRF should be one of the followings > > > > @@ -19,6 +22,8 @@ Required Properties: > > - compatible: PMUGRF should be one of the followings > > > > - "rockchip,rk3368-pmugrf", "syscon": for rk3368 > > - "rockchip,rk3399-pmugrf", "syscon": for rk3399 > > > > +- compatible: USB2GRF should be one of the followings > > + - "rockchip,rk3328-usb2phy-grf", "syscon": for rk3328 > > > > - reg: physical base address of the controller and length of memory > > mapped > > > > region. > > > > @@ -33,3 +38,13 @@ Example: GRF and PMUGRF of RK3399 SoCs > > > > compatible = "rockchip,rk3399-grf", "syscon"; > > reg = <0x0 0xff770000 0x0 0x10000>; > > > > }; > > > > + > > +Example: USB2GRF of RK3328 SoCs > > + > > + usb2phy_grf: syscon@ff450000 { > > + compatible = "rockchip,rk3328-usb2phy-grf", "syscon", > > + "simple-mfd"; > > simple-mfd is not documented. Do you have child nodes? Yes, this will have child nodes and I guess we don't really need the additional example, that only differs in the compatible. > What makes this a syscon? It has non-PHY registers? It is still a "General Register Files" block in all of the socs manual and yes, that special area also contains registers not used by the phy driver. Heiko