From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920AbbFAPvv (ORCPT ); Mon, 1 Jun 2015 11:51:51 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:51501 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883AbbFAPvf (ORCPT ); Mon, 1 Jun 2015 11:51:35 -0400 From: Arnd Bergmann To: Daniel Tang Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] devicetree: Add support for I2C and related devices to TI-NSPIRE platform Date: Mon, 01 Jun 2015 17:51:31 +0200 Message-ID: <1838480.tt9zIv1PRB@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1433065442-92750-1-git-send-email-dt.tangr@gmail.com> References: <1433065442-92750-1-git-send-email-dt.tangr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:duH1HnJgO9/UQ0mN+TV4yxgXt8kESpzrGPtQ0KAgdyimThMuqZB S0r7zIOO2KoI5y0mc1jzht/qNMW/bv/EUR/mU7ZHXPQk8HyJ4qHBMABpRLXsIc/PyJfyYjX sSPAJfTMrB9NawaxFTPyp+jKJhqGEx/L6O4TEW52HnCEFngn1Jl0LAX9L3XtzV4Swab7T41 cv7ALIWwWi7hagIdIxxMA== X-UI-Out-Filterresults: notjunk:1;V01:K0:+GVNzRRbpuU=:rS4BF+EN1Ee7Nio0IP3St0 a4pK5B83srrZ3WMQh3K1lHpIqiwSEj82RYm3QTgIVlKfueZUjQlZj3EBvAb8f2k+FWSaJW2DH aqlXRagFRgGRJKAIYYi+HCTsZ/j9Ng5rduSoYP/D+hMO5vlTb9UCcLQozpBHt/4g3rG9Poxq/ GgiQwHbSfp1xJeQ4u50cZPd/sbjSkr8449dIaEHSNPT/x5ZHpMQ0XFb37kzNhou8ubIjaYjMr Y61O5uNwG4jFDX3ZN3KGIGI5J8F0u2Kshcx9Mqyvz92JkgZ/a8Zr3vLdTI1mWckvDAykolEFu mBCNyjN/ldTgKi1aZyD5hOFFdu73bL55FiNlNKkI3wXlmWKrp7klCdNDI3n/Di+jxwRNzndPi CUWZAvJYEWa3PsfnRbFS0JRft3fP+U3IYscp4NrjEVGOnp5T8jPNsH0LIvHnM/hbyDK7VDWVP TZSEV7c8l4ZwLPFNS2jdXgrdUi+p5uAz6UJyPgLsccY3zpgByeqKasWUO5uGmAwHs/JFw4b6s q6wOCqNonuI6+MuXhEO/oc3HvVuttQhmyMV5gJ4XarVm0OlqnLBqXRKeKAEuHVzEOkyh+bZXq kZr5Ii9rbJp1RXYUXQK/Q+dAxn3tyLEko0JBsYh6GAjbD/TANjTHWG+qSQI8PzEFdUKWn/e/F nnQosQKxFqQShooly5RpP1zbwLzZq8oY/h+9LB0gi6WgjOg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 31 May 2015 19:44:02 Daniel Tang wrote: > + > + touchpad@20 { > + compatible = "synaptics_i2c"; > + reg = <0x20>; > + }; > }; While this works, "synaptics_i2c" is not a well-formed DT compatible string, we should do it right. Please submit three patches: a) one patch add "syna" as the vendor string in Documentation/devicetree/bindings/vendor-prefixes.txt As this is a publicly traded company, we use the stock ticker symbol by convention. Cc the patch to devicetree@vger.kernel.org for review, but I can merge it along with the dts patch if nobody else does b) a patch to add an of_device_id match table to drivers/input/mouse/synaptics_i2c.c, with the proper name of the device. Ideally, this would be the full name of the component that is used here, something like "syna,abc12345-touchscreen". If you have no way of finding out the real name, "syna,i2c-touchscreen" will have to suffice. c) This patch, with the correct string used for compatible. Arnd