From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2B6D28A1C9 for ; Thu, 24 Apr 2025 21:15:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745529321; cv=none; b=JryxDs156Q+iZtfbe4fSwyFUTwFx85YdA0aDzfm1OvAiQORMTvNsXtiguDHDO5P0HVcOfncPX+7u1J1vjkz0AJc4PccCWX5s807YQuoOON644sEOS19iYiLwfItAJpkRZ0v8qpMHU4x0zBin2DsDVsh/IVLgiW3es7dOZIkbPT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745529321; c=relaxed/simple; bh=HfnRpNKysoLGc1VbFc3ljccKHehzhI+ZIDvcoeCKWLw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XCy7sKZkE4UKekzfs9T3CdR5WI8CSWGN/y5qjHXxCirdrM3xRhI0YBb38Q4Pj3uns3MWl6951toYkFrRRSdxojXOSCGK7GQBwcqABiFoeNgL9lKM+BPUBmxqPumvaLQQfq9OFsKEK7hLIOh8nAkfK0nVfqbmbs8dhO0CgB9mInw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GHZYYeJU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GHZYYeJU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745529316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0atQVDH0XvpcRUPqJkcf4AWQNWnOP+JsltT1upRf5sI=; b=GHZYYeJUb3TOT7weRlmjmpIV7FnkZAE8OkA1yuHFNeLmGrydsY4PDMlnjknpIXS6tasFEM b8UYwXgqagssh0qhs3nRcGyYXtuOqNHRmtF92r3L4y870E2hfYGlzh7/00BPlh1B07wP6K 3dEIAjUzfPxUMZpyeStSV31h7KG4Gz0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-gDIb0r6APEikHuS9lz7rMg-1; Thu, 24 Apr 2025 17:15:12 -0400 X-MC-Unique: gDIb0r6APEikHuS9lz7rMg-1 X-Mimecast-MFC-AGG-ID: gDIb0r6APEikHuS9lz7rMg_1745529310 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-440a4e2bad7so371475e9.0 for ; Thu, 24 Apr 2025 14:15:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745529309; x=1746134109; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0atQVDH0XvpcRUPqJkcf4AWQNWnOP+JsltT1upRf5sI=; b=jInDYW1VaQjhc9KOQQD965zo+KxRT5LmPmVMxOLC2xs/SLf/Z/KgtGVKs2Ocs7ixR8 PSTo682QESmHqTOGaAnk9ra7rZY3NJhmbGN41fLC4sZctrlo2hZ4AUEdw9pE2yECbpmS bFy1dXPPPYM9mQX/6iGzmreiaStR/sHYftLHY5P7rTqjunvHNSM6QMGYpRU1LE31flGh enMPiifiSX9kkz1PPGrA5x5Oe9R/pkMhjGqHQKMjrCFch+tsypuoB/t5iSnNt3eu+j/i hSuCWBqRuMD7Up0LjYya52RjphKSQYxASomTorDjfQ0hSJBdOcLMLfgQxuXRT+6u6MX2 ei9Q== X-Forwarded-Encrypted: i=1; AJvYcCXqOFZ5y5DpuYE06Y25nsJEmOsVToff1pQ2SE2P5RA1w7sRB5FZumSuxnzMXClyy0v8ogflaQxx2VUIg1I=@vger.kernel.org X-Gm-Message-State: AOJu0YxOuFL3QZlMCMdKmadUB0KaIUsIj/XVgOLV31Kbj7qpvbx75fkX 86R1BeATXdrCWqIrZ4wHow60JyE3Tu1FEHIylS3zwWL3TL9cyWTzfHlBU5J5aSsiNmqf/disLYV Lc1DkAkdLyvO90N6Zar576gUjrxZbr+DDlLGG8q9qCdzXpEsfZE+JHucjC/gs3w== X-Gm-Gg: ASbGncuHfjR4naVKT2/EVM+oW1PJFzeNv9ZL6zBfb0W4NJBGXp+2YhtEVxs446MinGo wTH/tQV9a5Kn6JLBo2WluFN7uNMOJ/BkVjk2ODVZ7cGOMR46sdT/9jCFkM449hcA3k0twtPr65a +tTlZw7pwvACF9nxu0FQtu3qQgMH4F78IvEStaOV4zaewai7/odgNhaumA742T9c8NgoFgXNhiw fCs6S1ghf51Dci4B0L6AH+WVqdlvb36g7dcUwRlbwTYVQU/ET6lctCLi+n8XlluSON4RGBvTkhC yoDGwtHn0iWlZmhbWmvq140gNMmOwTkw47P0sNw90ztuAwqMkKJq0P1s9qs0vnl+pZDGjWzeceI UVVb/uueG+3YatPRRGAY7n3HbSxv5EHNYHbfw X-Received: by 2002:a05:600c:450a:b0:43d:16a0:d98d with SMTP id 5b1f17b1804b1-4409c4ddbbamr31013655e9.15.1745529309477; Thu, 24 Apr 2025 14:15:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGT7y3gX6fJnA7SugEtZIcpQd8krrY3RV3TcuqMt0VhvZW5tlI9puDVvH0e/UJAxRgT/uTzZg== X-Received: by 2002:a05:600c:450a:b0:43d:16a0:d98d with SMTP id 5b1f17b1804b1-4409c4ddbbamr31013415e9.15.1745529309144; Thu, 24 Apr 2025 14:15:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:ff00:f734:227:6936:cdab? (p200300cbc74eff00f73402276936cdab.dip0.t-ipconnect.de. [2003:cb:c74e:ff00:f734:227:6936:cdab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a536a021sm1708575e9.29.2025.04.24.14.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 14:15:08 -0700 (PDT) Message-ID: <1838f050-b4d0-4bbe-b76e-86c718f24162@redhat.com> Date: Thu, 24 Apr 2025 23:15:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/7] mm: Use for_each_valid_pfn() in memory_hotplug To: David Woodhouse , Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-7-dwmw2@infradead.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250423133821.789413-7-dwmw2@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.04.25 15:33, David Woodhouse wrote: > From: David Woodhouse > > Signed-off-by: David Woodhouse > Acked-by: Mike Rapoport (Microsoft) > --- > mm/memory_hotplug.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8305483de38b..8f74c55137bf 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1756,12 +1756,10 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > { > unsigned long pfn; > > - for (pfn = start; pfn < end; pfn++) { > + for_each_valid_pfn (pfn, start, end) { ^ > struct page *page; > struct folio *folio; > > - if (!pfn_valid(pfn)) > - continue; > page = pfn_to_page(pfn); > if (PageLRU(page)) > goto found; > @@ -1805,11 +1803,9 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > > - for (pfn = start_pfn; pfn < end_pfn; pfn++) { > + for_each_valid_pfn (pfn, start_pfn, end_pfn) { ^ Is there a reason for this space that I am unaware of? :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb