From: Sarbojit Ganguly <ganguly.s@samsung.com>
To: "SHARANALLUR<sharan.allur"@samsung.com,
"VIKRAMMUPPARTHI<vikram.m"@samsung.com,
Sarbojit Ganguly <ganguly.s@samsung.com>,
tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
Waiman.Long@hp.com, oleg@redhat.com,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
catalin.marinas@arm.com,
"RaghavendraKT<raghavendra.kt"@linux.vnet.ibm.com
Subject: [PATCH] arm: Adding support for atomic half word exchange
Date: Tue, 18 Aug 2015 08:17:52 +0000 (GMT) [thread overview]
Message-ID: <1842906637.213431439885869379.JavaMail.weblogic@ep2mlwas04b> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=windows-1252, Size: 1515 bytes --]
<Ping>
Since 16 bit half word exchange was not there and MCS based qspinlock by Waiman's xchg_tail() requires an atomic exchange on a half word, here is a small modification to __xchg() code to support the exchange.
ARMv6 and lower does not have support for LDREXH, so we need to make sure things do not break when we're compiling on ARMv6.
Signed-off-by: Sarbojit Ganguly <ganguly.s@samsung.com>
---
arch/arm/include/asm/cmpxchg.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/include/asm/cmpxchg.h b/arch/arm/include/asm/cmpxchg.h index 1692a05..547101d 100644
--- a/arch/arm/include/asm/cmpxchg.h
+++ b/arch/arm/include/asm/cmpxchg.h
@@ -50,6 +50,24 @@ static inline unsigned long __xchg(unsigned long x, volatile void *ptr, int size
: "r" (x), "r" (ptr)
: "memory", "cc");
break;
+#if !defined (CONFIG_CPU_V6)
+ /*
+ * Halfword exclusive exchange
+ * This is new implementation as qspinlock
+ * wants 16 bit atomic CAS.
+ * This is not supported on ARMv6.
+ */
+ case 2:
+ asm volatile("@ __xchg2\n"
+ "1: ldrexh %0, [%3]\n"
+ " strexh %1, %2, [%3]\n"
+ " teq %1, #0\n"
+ " bne 1b"
+ : "=&r" (ret), "=&r" (tmp)
+ : "r" (x), "r" (ptr)
+ : "memory", "cc");
+ break;
+#endif
case 4:
asm volatile("@ __xchg4\n"
"1: ldrex %0, [%3]\n"
--
Sarbojitÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next reply other threads:[~2015-08-18 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 8:17 Sarbojit Ganguly [this message]
2015-08-19 16:13 ` [PATCH] arm: Adding support for atomic half word exchange Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2015-07-10 7:50 Sarbojit Ganguly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1842906637.213431439885869379.JavaMail.weblogic@ep2mlwas04b \
--to=ganguly.s@samsung.com \
--cc="RaghavendraKT<raghavendra.kt"@linux.vnet.ibm.com \
--cc="SHARANALLUR<sharan.allur"@samsung.com \
--cc="VIKRAMMUPPARTHI<vikram.m"@samsung.com \
--cc=Waiman.Long@hp.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox