From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA89C433B4 for ; Tue, 13 Apr 2021 16:20:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D572611F0 for ; Tue, 13 Apr 2021 16:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242580AbhDMQU6 (ORCPT ); Tue, 13 Apr 2021 12:20:58 -0400 Received: from mail-ed1-f50.google.com ([209.85.208.50]:39773 "EHLO mail-ed1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbhDMQUz (ORCPT ); Tue, 13 Apr 2021 12:20:55 -0400 Received: by mail-ed1-f50.google.com with SMTP id g17so19354996edm.6 for ; Tue, 13 Apr 2021 09:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XayuMeXSD5c3FE14Gz9sb1594kQqDHscOmzXsH25B70=; b=qfuKtxb0VpVHL1X0JDFQCKt+pRuk1PNCztuZUnWa+SoDNf/PGkVhNpcVxsFA+pHbC6 UvvU+KjhAqx6LKXsKT8UeXHlFmjJNGZpgbuvj3cBEg2os3pvoX4Isp2k0lOkyARcxM1t c4XLaUB7yVDUUq2rJusHec4qUUT1l5oax9fb1tqxS0w8RPaj2LDeFYVSMMrCZsw8MR9h GvTq73QlsHhZY8flQkjzxgUD7pc4FKGpN4wWgwHoJYEeTa92PS+fTNzrx/7Yk9marXlV wI8Y19JdMAKJJ6sRaR4fqAbw/g6lKNrxoVYevwSjlaAzoPEaYE+igGZysNEYkhtWRQNv t8HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XayuMeXSD5c3FE14Gz9sb1594kQqDHscOmzXsH25B70=; b=HWNTmBGab4r6ygb34s6I6FUWeuGSN+jFUJwb/piPN2fWla+H02eCadkBoZi/NXKkW1 AOhdYqR6NYlvkLyatY5SYC/J+MBtZ0ub0DUCru9c+qTfkHmj8xJLHMIWebSi1rs69MBj 3lfrK49+xrlq8lNv40bEhtz4HUqgoJQhB/nii3XeEixqeKoPMVgrvMtyHbUPTtgMg8M/ e21LQ37Cp1NJJ7SzyceWHLIQaV/6ow2pNaXyxlX6rsOGeP8CkfwVd4043vPk/kPmJ6PW sWsCGRytcbUQsksUkilXjEl7XqVFUruNXLkmSv2nYlIhgQGtfx67+pO0Gzwp/UKDjGqT SPQA== X-Gm-Message-State: AOAM532p4o4zwW81RqtQ9+5XP9719GJsv4X9HOqaGOfBeek1xYkNR7Ni tHuCMVYf0XyDcTkS9mRSJ3s= X-Google-Smtp-Source: ABdhPJxg1K3uEAvQITGHMXwjXxO5W5SKdLQ51df71SJRdsIBxguNffcMBas1zxMru0ZMrLsTPS8r8w== X-Received: by 2002:a05:6402:757:: with SMTP id p23mr24082487edy.49.1618330774708; Tue, 13 Apr 2021 09:19:34 -0700 (PDT) Received: from linux.local (host-95-237-55-30.retail.telecomitalia.it. [95.237.55.30]) by smtp.gmail.com with ESMTPSA id ho11sm8082862ejc.112.2021.04.13.09.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 09:19:34 -0700 (PDT) From: "Fabio M. De Francesco" To: Julia Lawall Cc: outreachy-kernel@googlegroups.com, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] :staging: rtl8723bs: Remove useless led_blink_hdl() Date: Tue, 13 Apr 2021 18:19:33 +0200 Message-ID: <1843649.8FsqevVC75@linux.local> In-Reply-To: References: <20210413155908.8691-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="US-ASCII" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, April 13, 2021 6:04:16 PM CEST Julia Lawall wrote: > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote: > > Removed the led_blink_hdl() function (declaration, definition, and > > caller code) because it's useless. It only seems to check whether or > > not a given pointer is NULL. There are other (simpler) means for that > > purpose. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 1 - > > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 9 --------- > > drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 1 - > > 3 files changed, 11 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c > > b/drivers/staging/rtl8723bs/core/rtw_cmd.c index > > 0297fbad7bce..4c44dfd21514 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > > @@ -150,7 +150,6 @@ static struct cmd_hdl wlancmds[] = { > > > > GEN_MLME_EXT_HANDLER(0, h2c_msg_hdl) /*58*/ > > GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelPlan_param), > > set_chplan_hdl) /*59*/> > > - GEN_MLME_EXT_HANDLER(sizeof(struct LedBlink_param), led_blink_hdl) > > /*60*/ > This is worrisome. Doyou fully understand the impact of this? If not, > the change is probably not a good idea. > This is that macro definition: #define GEN_MLME_EXT_HANDLER(size, cmd) {size, cmd}, struct C2HEvent_Header { #ifdef __LITTLE_ENDIAN unsigned int len:16; unsigned int ID:8; unsigned int seq:8; #else unsigned int seq:8; unsigned int ID:8; unsigned int len:16; #endif unsigned int rsvd; }; It's a bit convoluted with regard to my experience. Probably I don't understand it fully, but it seems to me to not having effects to the code where I removed its use within core/rtw_cmd.c. What am I missing? Thanks for your kind help, Fabio > > julia > > > GEN_MLME_EXT_HANDLER(sizeof(struct SetChannelSwitch_param), > > set_csa_hdl) /*61*/ GEN_MLME_EXT_HANDLER(sizeof(struct > > TDLSoption_param), tdls_hdl) /*62*/> > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > > b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index > > 440e22922106..6f2a0584f977 100644 > > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > > @@ -6189,15 +6189,6 @@ u8 set_chplan_hdl(struct adapter *padapter, > > unsigned char *pbuf)> > > return H2C_SUCCESS; > > > > } > > > > -u8 led_blink_hdl(struct adapter *padapter, unsigned char *pbuf) > > -{ > > - > > - if (!pbuf) > > - return H2C_PARAMETERS_ERROR; > > - > > - return H2C_SUCCESS; > > -} > > - > > > > u8 set_csa_hdl(struct adapter *padapter, unsigned char *pbuf) > > { > > > > return H2C_REJECTED; > > > > diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h > > b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h index > > 5e6cf63956b8..472818c5fd83 100644 > > --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h > > +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h > > @@ -745,7 +745,6 @@ u8 chk_bmc_sleepq_hdl(struct adapter *padapter, > > unsigned char *pbuf);> > > u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf); > > u8 set_ch_hdl(struct adapter *padapter, u8 *pbuf); > > u8 set_chplan_hdl(struct adapter *padapter, unsigned char *pbuf); > > > > -u8 led_blink_hdl(struct adapter *padapter, unsigned char *pbuf); > > > > u8 set_csa_hdl(struct adapter *padapter, unsigned char *pbuf); /* > > Kurt: Handling DFS channel switch announcement ie. */ u8 > > tdls_hdl(struct adapter *padapter, unsigned char *pbuf); > > u8 run_in_thread_hdl(struct adapter *padapter, u8 *pbuf); > > > > -- > > 2.31.1 > > > > -- > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. To unsubscribe from this group and > > stop receiving emails from it, send an email to > > outreachy-kernel+unsubscribe@googlegroups.com. To view this discussion > > on the web visit > > https://groups.google.com/d/msgid/outreachy-kernel/20210413155908.8691 > > -1-fmdefrancesco%40gmail.com.