From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753797AbdJIHtm (ORCPT ); Mon, 9 Oct 2017 03:49:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41834 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbdJIHtk (ORCPT ); Mon, 9 Oct 2017 03:49:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5DE32C04AC63 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Date: Mon, 9 Oct 2017 03:49:38 -0400 (EDT) From: Paolo Bonzini To: "Tobin C. Harding" Cc: rkrcmar@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <1845029054.11118038.1507535378802.JavaMail.zimbra@redhat.com> In-Reply-To: <1507530614-10504-1-git-send-email-me@tobin.cc> References: <1507530614-10504-1-git-send-email-me@tobin.cc> Subject: Re: [PATCH] KVM: remove printing of token address MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.36.116.154, 10.4.196.18, 10.4.195.5] Thread-Topic: remove printing of token address Thread-Index: UWOaz64zD8DgEnLboNaiwsgkF1ORdA== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 09 Oct 2017 07:49:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: "Tobin C. Harding" > To: "Paolo Bonzini" , rkrcmar@redhat.com > Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Tobin C. Harding" > Sent: Monday, October 9, 2017 8:30:14 AM > Subject: [PATCH] KVM: remove printing of token address > > KVM currently prints the address of the consumer token. It is not > immediately clear what benefit it is to see this address. Printing > this address leaks kernel pointers into dmesg and is a security risk. > > Remove the consumer token address from error message output. It should use %pK instead. Also, please do the same change on the VFIO side (drivers/vfio/pci/vfio_pci_intrs.c, call to irq_bypass_register_producer). Thanks, Paolo > > Signed-off-by: Tobin C. Harding > --- > virt/kvm/eventfd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index f2ac53ab8243..b54503ed60bd 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -416,8 +416,7 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args) > irqfd->consumer.start = kvm_arch_irq_bypass_start; > ret = irq_bypass_register_consumer(&irqfd->consumer); > if (ret) > - pr_info("irq bypass consumer (token %p) registration fails: %d\n", > - irqfd->consumer.token, ret); > + pr_info("irq bypass consumer registration fails: %d\n", ret); > } > #endif > > -- > 2.7.4 > >