From: hooanon05@yahoo.co.jp
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "\" \" J. A. Magallón \" \"" <jamagallon@ono.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-nfs@vger.kernel.org, Trond.Myklebust@netapp.com
Subject: Re: Problems with default ACLs over NFS
Date: Sat, 28 Mar 2009 07:50:55 +0900 [thread overview]
Message-ID: <18513.1238194255@jrobl> (raw)
In-Reply-To: <20090326170513.4e7d377a.akpm@linux-foundation.org>
> On Mon, 23 Mar 2009 22:24:27 +0100 "J.A. Magall__n" <jamagallon@ono.com> wrote:
>
> > Hi all...
> >
> > I have a strange problem with 2.6.29-rc8-git3.
> > It looks like a kernel bug... ?
> >
> > I have a box with NFS autofs-mounted home directories. Server is a
> > Solaris 10 system. This worked in previous kernel versions, so I
> > don't blame Solaris, at this moment.
> >
> > With this acls set in my home:
:::
> > I get this strange message in the linux client:
> >
> > cicely:~> mkdir kk
> > mkdir: cannot create directory `kk': Invalid argument
I met a similar problem.
In linux-2.6.29 with CONFIG_NFS_V3_ACL enabled,
when I executed "cp -p /local/ext2/file /nfsv3/file", I got EINVAL too.
Strace-ing this cp, I found setxsttr() return EINVAL. Before 2.6.29, it
was EOPNOTSUPPORTED.
Tracing some kernel functions, I observed several thigs.
- xdr_buf_subsegment() returned -1 due to 'len' is not 0.
- xdr_encode_word() call from nfsacl_encode() got this -1, and
nfsacl_encode/nfs3_xdr_setaclargs/nfs3_proc_setacls/nfs3_proc_setacl/nfs3_setxattr
returned -EINVAL.
Finally I am afraid this commit might be related to this issue.
commit ae46141ff08f1965b17c531b571953c39ce8b9e2
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Tue Mar 10 20:33:18 2009 -0400
NFSv3: Fix posix ACL code
Fix a memory leak due to allocation in the XDR layer. In cases where the
RPC call needs to be retransmitted, we end up allocating new pages without
clearing the old ones. Fix this by moving the allocation into
nfs3_proc_setacls().
Also fix an issue discovered by Kevin Rudd, whereby the amount of memory
reserved for the acls in the xdr_buf->head was miscalculated, and causing
corruption.
J. R. Okajima
next prev parent reply other threads:[~2009-03-27 22:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 21:24 Problems with default ACLs over NFS J.A. Magallón
2009-03-27 0:05 ` Andrew Morton
2009-03-27 22:50 ` hooanon05 [this message]
2009-04-20 4:42 ` Suresh Jayaraman
2009-04-20 5:17 ` hooanon05
2009-04-20 5:35 ` Suresh Jayaraman
2009-04-20 14:18 ` Sven Geggus
2009-04-21 5:00 ` Suresh Jayaraman
-- strict thread matches above, loose matches on Subject: below --
2009-04-19 15:03 Sven Geggus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18513.1238194255@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=jamagallon@ono.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox