The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@it.uu.se>
To: David Miller <davem@davemloft.net>
Cc: marcel@holtmann.org, linux-kernel@vger.kernel.org,
	sfr@canb.auug.org.au, linuxppc-dev@ozlabs.org,
	akpm@linux-foundation.org, torvalds@linux-foundation.org,
	kkeil@suse.de
Subject: Re: mISDN still breaking the allmodconfig build...
Date: Mon, 28 Jul 2008 03:57:15 +0200	[thread overview]
Message-ID: <18573.10107.853761.684410@harpo.it.uu.se> (raw)
In-Reply-To: <20080727.180736.74131389.davem@davemloft.net>

David Miller writes:
 > From: Marcel Holtmann <marcel@holtmann.org>
 > Date: Mon, 28 Jul 2008 03:03:04 +0200
 > 
 > > > More fallout from the premature mISDN driver merge:
 > > >
 > > > drivers/isdn/hardware/mISDN/hfcmulti.c:5255:2: error: #error "not  
 > > > running on big endian machines now"
 > > 
 > > is that only the HFC driver or the whole mISDN stack?
 > > 
 > > I know that the two old ISDN stacks where really bad on big endian,  
 > > but my assumption was that we did sort this out in the end.
 > 
 > One of the two mISDN drivers uses the deprecated virt_to_bus()
 > interface for handling DMA addresses (that doesn't even work on many
 > x86 systems these days) and the other mISDN driver gives the above
 > big-endian compile time error.
 > 
 > In short, this driver was not ready for merging at all.

Why on earth does a generic (I hope) protocol driver (some ISDN
thingy in this case) care about endianess at all?

Or has things come to a "the world's an x86" ("the world's a VAX" for
old-timers but add 25+ years or so) situation where the majority of
coders don't even consider that machines might be different from what
they use? If so, a deep sigh of sadness.

(Not that I prefer a particular endianess. My point being that coders
shouldn't make endianess assumptions unless they're really^3 important.)>

  parent reply	other threads:[~2008-07-28  1:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28  0:02 mISDN still breaking the allmodconfig build David Miller
2008-07-28  0:13 ` Benjamin Herrenschmidt
2008-07-28  0:48   ` Sean MacLennan
2008-07-28  9:20     ` Alan Cox
2008-07-28 11:14       ` Karsten Keil
2008-07-28  1:03 ` Marcel Holtmann
2008-07-28  1:07   ` David Miller
2008-07-28  1:13     ` Marcel Holtmann
2008-07-28  8:40       ` Karsten Keil
2008-07-28 12:49         ` Sinan Akman
2008-08-04 12:56           ` Karsten Keil
2008-07-28  1:57     ` Mikael Pettersson [this message]
2008-07-28 10:26     ` Karsten Keil
2008-07-28 10:50   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18573.10107.853761.684410@harpo.it.uu.se \
    --to=mikpe@it.uu.se \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=marcel@holtmann.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox