Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check()

David Howells
2007-02-20T10:45:25Z

Oleg Nesterov <oleg@tv-sign.ru> wrote:

> static void release_nbp(struct kobject *kobj)
> {
> struct net_bridge_port *p
> = container_of(kobj, struct net_bridge_port, kobj);
> +
> + dev_put(p->dev);

Does this need to be done with the mutex held? And does anything actually pay
attention to the refcount on dev? I assume not...

Should you clear p->dev->br_port before calling dev_put()?

Looks reasonable. I like it.

Acked-By: David Howells <dhowells@redhat.com>