From: David Howells <dhowells@redhat.com>
To: yannik@sembritzki.me
Cc: dhowells@redhat.com, torvalds@linux-foundation.org,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, dyoung@redhat.com,
James.Bottomley@HansenPartnership.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/2] Replace magic for trusting the secondary keyring with #define
Date: Thu, 16 Aug 2018 14:15:19 +0100 [thread overview]
Message-ID: <18610.1534425319@warthog.procyon.org.uk> (raw)
In-Reply-To: <153442471049.17751.3835342719465644394.stgit@warthog.procyon.org.uk>
Hi Yannik,
I would suggest something like that. I've switched the patches over as has
been suggested. I think it makes more sense to create the constant first and
then use that.
I've also fleshed out the patch description a bit and added cc and Fixes
fields as appropriate.
David
next prev parent reply other threads:[~2018-08-16 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 13:05 [PATCH 1/2] Replace magic for trusting the secondary keyring with #define David Howells
2018-08-16 13:05 ` [PATCH 2/2] Fix kexec forbidding kernels signed with keys in the secondary keyring to boot David Howells
2018-08-16 13:15 ` David Howells [this message]
2018-08-16 13:17 ` [PATCH 1/2] Replace magic for trusting the secondary keyring with #define Yannik Sembritzki
2018-08-16 15:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18610.1534425319@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dyoung@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yannik@sembritzki.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox