From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbeENJpZ (ORCPT ); Mon, 14 May 2018 05:45:25 -0400 Received: from gloria.sntech.de ([95.129.55.99]:42456 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbeENJpX (ORCPT ); Mon, 14 May 2018 05:45:23 -0400 From: Heiko Stuebner To: Elaine Zhang , linux-pm@vger.kernel.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, wxt@rock-chips.com, xxx@rock-chips.com, xf@rock-chips.com, huangtao@rock-chips.com, Finley Xiao Subject: Re: [PATCH v2 04/13] soc: rockchip: power-domain: Fix wrong value when power up pd Date: Mon, 14 May 2018 11:45:05 +0200 Message-ID: <1861053.XlXe5vHN1s@phil> In-Reply-To: <1526268578-9361-1-git-send-email-zhangqing@rock-chips.com> References: <1526268455-9133-1-git-send-email-zhangqing@rock-chips.com> <1526268578-9361-1-git-send-email-zhangqing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Elaine, Am Montag, 14. Mai 2018, 05:29:38 CEST schrieb Elaine Zhang: > From: Finley Xiao > > Solve the pd could only ever turn off but never turn them on again, > If the pd registers have the writemask bits. > > Fix up the code error for commit: > commit 79bb17ce8edb3141339b5882e372d0ec7346217c > Author: Elaine Zhang > Date: Fri Dec 23 11:47:52 2016 +0800 > > soc: rockchip: power-domain: Support domain control in hiword-registers > > New Rockchips SoCs may have their power-domain control in registers > using a writemask-based access scheme (upper 16bit being the write > mask). So add a DOMAIN_M type and handle this case accordingly. > Signed-off-by: Elaine Zhang > Signed-off-by: Heiko Stuebner > > Signed-off-by: Finley Xiao > Signed-off-by: Elaine Zhang As Gregs automated mail noted, the stable-notice needed some changes. I've done these changes and applied the result for 4.18. When you look at [0] you'll see the two lines "Fixes:..." and "Cc:..." in the commit message. Greg then has automated scripts running that extract so marked patches from Linus' tree and queue them for possible stable-inclusion. [The other patches need to wait a bit to give Rob a chance to Ack them] Heiko [0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=ed726894761c056b3513ce15915af74ce5d7d57b