public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-kernel@vger.kernel.org, paulus@samba.org
Subject: Re: Some compiler warnings in 2.4.17-pre5
Date: Sat, 08 Dec 2001 09:47:56 +0000	[thread overview]
Message-ID: <18634.1007804876@redhat.com> (raw)
In-Reply-To: <Pine.NEB.4.43.0112070005300.8687-200000@mimas.fachschaften.tu-muenchen.de>
In-Reply-To: <Pine.NEB.4.43.0112070005300.8687-200000@mimas.fachschaften.tu-muenchen.de>


bunk@fs.tum.de said:
>  [both jffs2 and ppp have own copies of zlib]

They have identical copies of zlib, except for a typo fix in a comment in 
the PPP version which was made after I copied it. It's probably worth 
hacking the makefiles so that only one gets built and included.

In due course, the new zlib in fs/inflate_fs will get expanded to do 
compression as well as decompression, and moved out of fs/ where it doesn't 
really belong. At that point, JFFS2 and PPP can both use that.

You could prefix all the non-static symbols in either or both of these zlib 
copies with 'ppp_' or 'jffs2_', but I prefer not to do that as it's just 
hiding the problem, not fixing it.

--
dwmw2



  reply	other threads:[~2001-12-08  9:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-07 23:16 Some compiler warnings in 2.4.17-pre5 Adrian Bunk
2001-12-08  9:47 ` David Woodhouse [this message]
2001-12-08 11:37 ` Alan Cox
2001-12-12 19:17   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18634.1007804876@redhat.com \
    --to=dwmw2@infradead.org \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox