Re: [patch] 2.4.6-pre3 unresolved symbol do_softirq

[Keith Owens <kaos@ocs.com.au>]

On Wed, 13 Jun 2001 07:55:49 -0700 (PDT), 
"David S. Miller" <davem@redhat.com> wrote:
>
>Andreas Schwab writes:
> > "David S. Miller" <davem@redhat.com> writes:
> > 
> > |> I can't believe there is no reliable way to get rid of that
> > |> pesky "$" gcc is adding to the symbol.  Oh well...
> > 
> > Use %c0.  *Note Output Templates and Operand Substitution: (gcc)Output
> > Template.
>
>Nice, see Keith?  There are no excuses :-)

Oh, there are always excuses ;).  But in this case ...

Index: 6-pre3.1/include/asm-i386/softirq.h
--- 6-pre3.1/include/asm-i386/softirq.h Sat, 09 Jun 2001 11:25:53 +1000 kaos (linux-2.4/T/51_softirq.h 1.3 644)
+++ 6-pre3.1(w)/include/asm-i386/softirq.h Thu, 14 Jun 2001 02:26:16 +1000 kaos (linux-2.4/T/51_softirq.h 1.3 644)
@@ -36,13 +36,13 @@ do {									\
 									\
 			".section .text.lock,\"ax\";"			\
 			"2: pushl %%eax; pushl %%ecx; pushl %%edx;"	\
-			"call do_softirq;"				\
+			"call %c1;"					\
 			"popl %%edx; popl %%ecx; popl %%eax;"		\
 			"jmp 1b;"					\
 			".previous;"					\
 									\
 		: /* no output */					\
-		: "r" (ptr)						\
+		: "r" (ptr), "i" (do_softirq)				\
 		/* no registers clobbered */ );				\
 } while (0)
 
No changes to kernel/ksyms, it still says EXPORT_SYMBOL(do_softirq);  I like it.