Re: [RFC] changes to buffer.c (was Test12 ll_rw_block error)

Chris Mason
2000-12-22T15:41:01Z

On Thursday, December 21, 2000 22:38:04 -0200 Marcelo Tosatti
<marcelo@conectiva.com.br> wrote:

>> Marcelo Tosatti writes:
>> > It seems your code has a problem with bh flush time.
>> >
>> > In flush_dirty_buffers(), a buffer may (if being called from kupdate)
>> > only be written in case its old enough. (bh->b_flushtime)
>> >
>> > If the flush happens for an anonymous buffer, you'll end up writing all
>> > buffers which are sitting on the same page (with
>> > block_write_anon_page), but these other buffers are not necessarily
>> > old enough to be flushed.
>>

A quick benchmark shows there's room for improvement here. I'll play
around with a version of block_write_anon_page that tries to be more
selective when flushing things out.

-chris