From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A163C47404 for ; Wed, 9 Oct 2019 14:06:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2156D21848 for ; Wed, 9 Oct 2019 14:06:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="WJ7+4jX1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731335AbfJIOGb (ORCPT ); Wed, 9 Oct 2019 10:06:31 -0400 Received: from mail-eopbgr700080.outbound.protection.outlook.com ([40.107.70.80]:53185 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731259AbfJIOGa (ORCPT ); Wed, 9 Oct 2019 10:06:30 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cJAibaNK/11jbBxvveiid2iaLQ5QtUegOUwYjj4ByCSOu6JM2nWwffuBvWIcZUbAiPa31qf6m0wj0bqfB6SvkH99Hcp743Pa0pHgtDnn693K7AMjuHXNJ8cKLRphfJ8gkuYaIz227VjZr2UNqFqaYJYRyfcXvckFRHL4Bs5KMfcwOjtwxK9iSBtVYEal1crHKD1MZW2q1rmFh2Lv+xp2DjEL4w0J1QfsZG3mwTLLOOedo49wL8H8EOUt7O5pAdB9Z8LMCxvJDtGOq1xQDzrkgULrI4Wk157jCjMfw/zYy4RuPG4s7NVTCKTrmSsiSIIZ3JgTcijJ0KYl7ws72AxTEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwVAe0pVIWbduqRWho3sAAmCBgHR8uabmoTlUXIqPIc=; b=CDmjuIVtMyJtDL4JAEodP/+XY0clxBNT1b1L6/Fum91TwE4rXJuqzBxSRUE5eEUap5BATy6SSMnJIJrRC2eNGEcW/Xpr8YXaJ31dyQ6wln+6ZKkjZr/BxXgdsewrBUxgAEwsFscvCdrYaHoNbIdl1u15rnjMqAe7J6+yXYztUEdbBaz9z/GTSyfs0r03au3EEMjqAznTP4eIXGFZB/dsxlUtsHfUtTtUCoZUWps2Mo5yN8tmLZCJ9c7WorQsqx0P7NpIRKK9rtAujbx5f6ZY4fxznzA0uMPnnICmLzNR3j6u6pYrhEdBwrs7CrDE6mBA+u5lAchoCZq4OzcF3Cy5Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwVAe0pVIWbduqRWho3sAAmCBgHR8uabmoTlUXIqPIc=; b=WJ7+4jX1ZVM6kT37/HLw2jHL9YFHBLIbE/VGYcNkKUmjSAlfQGcApBv5puxgmeItuoxJdXe2+IPOqF8c2iDPNzSvq5QrEPkc+pwucaWTqRlgch6sio4rej13Uzm6WoJoHa2l8tsUwpDw0GwmwBXJO/nxhky1PEt8kvDKPbzYU30= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB4301.namprd11.prod.outlook.com (52.135.36.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Wed, 9 Oct 2019 14:06:28 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ac8c:fc55:d1e2:465f]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ac8c:fc55:d1e2:465f%5]) with mapi id 15.20.2347.016; Wed, 9 Oct 2019 14:06:27 +0000 From: Jerome Pouiller To: Colin King CC: Greg Kroah-Hartman , "devel@driverdev.osuosl.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] staging: wfx: fix swapped arguments in memset call Thread-Topic: [PATCH][next] staging: wfx: fix swapped arguments in memset call Thread-Index: AQHVfoZg5uodYV7VWEaEUqiihC082adSWG6A Date: Wed, 9 Oct 2019 14:06:27 +0000 Message-ID: <1869130.EaR14QUEFT@pc-42> References: <20191009094602.19663-1-colin.king@canonical.com> In-Reply-To: <20191009094602.19663-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92037824-63e4-4a1d-7358-08d74cc1e0c6 x-ms-traffictypediagnostic: MN2PR11MB4301: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 018577E36E x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(39850400004)(376002)(346002)(396003)(136003)(366004)(189003)(199004)(14444005)(66066001)(86362001)(33716001)(71190400001)(71200400001)(9686003)(6512007)(478600001)(256004)(486006)(5660300002)(446003)(11346002)(476003)(14454004)(66574012)(25786009)(7736002)(99286004)(91956017)(8936002)(229853002)(4326008)(186003)(6246003)(76116006)(66946007)(54906003)(64756008)(66476007)(76176011)(26005)(2906002)(81166006)(66556008)(305945005)(6506007)(66446008)(6436002)(316002)(81156014)(6916009)(102836004)(8676002)(3846002)(6116002)(6486002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB4301;H:MN2PR11MB4063.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pyiXl/ah8IDAZ5hS23Booc0fP5o2U9O1fwYmLORonu5RX20+Yr6Vv4hrpOf4Qy+lq7p6C56swwMq9b1zM4VrZMjcu8Pc448sD8iMt/6uerNKNByqT/GxPmugYCjGMEEGusH3x4Gc2JjP31ESpC3YikEBst2qqPR1b1lf2smRr3UQ7GIXWAcjvw6gJaR0XWdf05hHDDTkhtbXYF+eRc5tbB0fnm1JqpAlEGaVKJ4CoeSvgFU+dUPcLGdSCazE7NxsCPts+wDniwzy03Y/4dCGRjf+g/4bVm/i6jie3Exvwz7WTZNLsRHU6mjt5K9dYEHeqP8ZlmIsEdrXS14tllFVN9di83XGwpWnrcJlwkVhsF8kmmVvCFyAWgdm8rBFhF4fkZsdEBNYx5Dh5QauHavCagfqqUDQWuRrDICaGer8FMc= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92037824-63e4-4a1d-7358-08d74cc1e0c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2019 14:06:27.8226 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ta8+jeZC3dGRupQ/AWV1fqnWKm+SnQa6PJqpi+RL3iPpShev+pQ+rqTseZCJMo062G+jpIkxjYASiwHXQGG5Aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4301 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 9 October 2019 11:46:08 CEST Colin King wrote: > From: Colin Ian King >=20 > The memset appears to have the 2nd and 3rd arguments in the wrong > order, fix this by swapping these around into the correct order. >=20 > Addresses-Coverity: ("Memset fill truncated") > Fixes: 4f8b7fabb15d ("staging: wfx: allow to send commands to chip") > Signed-off-by: Colin Ian King > --- > drivers/staging/wfx/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c > index 8de16ad7c710..761ad9b4f27e 100644 > --- a/drivers/staging/wfx/debug.c > +++ b/drivers/staging/wfx/debug.c > @@ -226,7 +226,7 @@ static ssize_t wfx_send_hif_msg_write(struct file *fi= le, const char __user *user > // wfx_cmd_send() chekc that reply buffer is wide enough, but do = not > // return precise length read. User have to know how many bytes s= hould > // be read. Filling reply buffer with a memory pattern may help u= ser. > - memset(context->reply, sizeof(context->reply), 0xFF); > + memset(context->reply, 0xFF, sizeof(context->reply)); > request =3D memdup_user(user_buf, count); > if (IS_ERR(request)) > return PTR_ERR(request); Ouch! I realize that "-Wmemset-transposed-args" and/or "-Wmemset-elt-size" don't catch this case. Thank you for your attentive reading. Reviewed-by: J=E9r=F4me Pouiller --=20 J=E9r=F4me Pouiller