From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1C8C4338F for ; Sun, 22 Aug 2021 16:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 427AB61247 for ; Sun, 22 Aug 2021 16:24:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230054AbhHVQZH (ORCPT ); Sun, 22 Aug 2021 12:25:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbhHVQZF (ORCPT ); Sun, 22 Aug 2021 12:25:05 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A46D6C061575 for ; Sun, 22 Aug 2021 09:24:24 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id d6so22276700edt.7 for ; Sun, 22 Aug 2021 09:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5TsWkpCa9oK0Y3XatOG1ojrJ9dXPyqHirLcQPTkgsZ4=; b=H8+jNCTiRlPQ0Eky1gTfskoYJCB2AEUsT8c3Jhv7gzfrhn5CnK7Ed4GwEWbnzxg6nc CGi2Jh4MuWU75LF7w65eIF3jXHh59OvAGuTQQIovfT7Gh6bZBJHfA/t/BJ5Xqzf4Jch8 wSg3vi6azb1onEOiCP9wlYkG8bxVDPJEy0dWfGMhomW5tGzWI29MkCL+HQ2ojzPn2voz I+Yw82BgBnn1BL/lYtHJnZ9KRBHXB5CRw8kJCb0iXlyToTrSyKBXJtAdbwJKnPXQQDaO wj7tq5vRPICYJ4d1JBhqutD3c6iDGXPa3kYt8gkY4iWD8KF3lY4B2Z3T8iWqcKa6/rya FnuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5TsWkpCa9oK0Y3XatOG1ojrJ9dXPyqHirLcQPTkgsZ4=; b=O8hYRsi7ajJm8BQVVMJfd+p68yW/qDu9adxCLQrRYrdcFjlSx0cWaRPdTogzhfKjnt GEFJ6yIXM42gdyNfQKohxrh2Qb343/UeFrSaXmTIARPYNbzn+eyog4jX+3Lng0D/H/zv S9kBDdhHWP4L/1UVMJRIMRYyrX/Go9QC/E/TvjFwRt3loQOBXduQuEzzSZ/qckblXa8i YGIhaoCbWAPBYbcxSR/E5rVRoHeFLpYpOf8uCV5ynJt1zaahrzRE9QTdRuyjfsIbyCDv U5P1BwssYczhH98GWzMc3XmOn1uZ1CjuzkFp9I8rScVrinpjXWzbKN2h+gBMX1yXY5GH IBYw== X-Gm-Message-State: AOAM532Bs5TKPEK6YdgocCq6hIvkG0k0ejkUjEUuPSdZbb6uK/9HSKUL PcOX+WP3SZBxdHoCG8wPccw= X-Google-Smtp-Source: ABdhPJwU0xskbCrPLwjN+G10gF9G2qoXqQzWCKWBoZ/HKaKRzgsZUoup84dCZ3zUYbv3NNd5R2ZI1g== X-Received: by 2002:a05:6402:270a:: with SMTP id y10mr32920074edd.385.1629649463180; Sun, 22 Aug 2021 09:24:23 -0700 (PDT) Received: from localhost.localdomain (host-79-22-100-164.retail.telecomitalia.it. [79.22.100.164]) by smtp.gmail.com with ESMTPSA id p5sm3532142eju.30.2021.08.22.09.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Aug 2021 09:24:22 -0700 (PDT) From: "Fabio M. De Francesco" To: Phillip Potter Cc: Saurav Girepunje , Larry Finger , Greg KH , linux-staging@lists.linux.dev, Linux Kernel Mailing List , saurav.girepunje@hotmail.com Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect Date: Sun, 22 Aug 2021 18:24:21 +0200 Message-ID: <18734228.Nv2I6EOGHm@localhost.localdomain> In-Reply-To: References: <1821445.fzUCeO1EU3@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, August 22, 2021 4:58:10 PM CEST Phillip Potter wrote: > Dear Fabio, > > An Acked-by merely signals acknowledgement of the patch, and that is > looks OK to the person offering the tag. Please see the following > quote from the kernel.org documentation: > "Acked-by: is not as formal as Signed-off-by:. It is a record that the > acker has at least reviewed the patch and has indicated acceptance." > It is not, to my knowledge, a commitment from the reviewer that the > patch applies to the given tree at that precise moment in time. Dear Philip, I didn't mean to be harsh with you, I apologize if this is the message I conveyed. Really! > I reviewed the patch, and indicated my acceptance - the content of the > patch is fine. Whilst I will often make an effort to merge + build > test many patches, I will not do this with all of them, I simply don't > have the time due to other commitments. You can be assured that if I > have offered this tag I have at least read the patch and it looks > correct to me. Now it is clearer to me what acking means. I've given only a handful of acks because I thought I should also check if they applied and if they build. It takes time. Now I understand it is not required. Thanks. > Particularly with a driver as in flux as this one, there are going to > be many merge conflicts. Advice such as this to me is not particularly > helpful, as I can promise you I'm trying :-) Please, don't ever think I'm not more than sure that you give a lot of your _unpaid_ time to the kernel and I thank you very much I know what it means, because I too have other commitments :-) Cheers, Fabio > Regards, > Phil >