From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbdKJPbp (ORCPT ); Fri, 10 Nov 2017 10:31:45 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:44595 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbdKJPbn (ORCPT ); Fri, 10 Nov 2017 10:31:43 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171110153141epoutp01a24911e3515435299b2d9275b1322561~1wzlZzKVT1753717537epoutp01P X-AuditID: b6c32a45-333ff70000001129-d1-5a05c65c6257 From: Bartlomiej Zolnierkiewicz To: Kees Cook Cc: "Gustavo A. R. Silva" , Himanshu Jha , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: pxa3xx_gcu: Convert timers to use timer_setup() Date: Fri, 10 Nov 2017 16:31:38 +0100 Message-id: <1873548.3BWMf1Kard@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20171109184840.GA115388@beast> MIME-version: 1.0 Content-type: text/plain; charset="utf-8" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWy7bCmmW7MMdYog4fXVCyufH3PZrF1j6rF tDUtrBZnunMtTvR9YLW4vGsOmwObx+yGiywe6w6qeuycdZfd4373cSaPz5vkAlijuGxSUnMy y1KL9O0SuDKe/GphLpjMU7Gu+SJ7A2M3VxcjJ4eEgInEiic/2bsYuTiEBHYwStztXM4E4Xxn lLj1ZT0TTNXitTdZIBK7GSWmf9nDCOF8ZZSYcbaRFaSKTcBKYmL7KkYQW0RAVeL7pWZmkCJm gX2MEh/+LmMBSQgLhEjsn3CbDcRmASqaMG0nmM0roCmxesVNdhBbVMBLYsu+dqDVHBycAjoS K4/4QpQISvyYfA9sDLOAtsSTdxdYIWxNiRdfJoFdJyGwhU1iz6kjjBBnu0ismfKXFcIWlnh1 fAs7hC0t8WzVRqia6YwS239LQDRvZpRYtXsCVJG1xOHjF6E28El0HP7LDnKQhACvREebEESJ h8S89hYWCNtR4uS+i2AzhQTqJdZMmsg0gVF2FpK7ZyG5exaSuxcwMq9iFEstKM5NTy02KjDU K07MLS7NS9dLzs/dxAhOC1quOxhnnPM5xCjAwajEw/vhLkuUEGtiWXFl7iFGCQ5mJRHewHms UUK8KYmVValF+fFFpTmpxYcYpTlYlMR567ddixASSE8sSc1OTS1ILYLJMnFwSjUwOvtNNIkM nOAt4Jkax2d45sOrf1X2ajfPWNz2jDM67bH89PdLHF6PQg+0Odrd7nP6KfJ00ZaK8w5flh6r fv3usOx1A4YlzgsvpS1c37dvSnxekLpKZYlNbqKs+NU9F4IY7JVfLy7xkVW/fy147Y+Gl6zG LXY9CvkcjgxTL8XvW79QtCZftb1MiaU4I9FQi7moOBEAsHZXVgcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t9jAd2YY6xRBg/mSVpc+fqezWLrHlWL aWtaWC3OdOdanOj7wGpxedccNgc2j9kNF1k81h1U9dg56y67x/3u40wenzfJBbBGcdmkpOZk lqUW6dslcGU8+dXCXDCZp2Jd80X2BsZuri5GTg4JAROJxWtvsnQxcnEICexklNi08To7hPOV UWJ12xYmkCo2ASuJie2rGEFsEQFVie+XmplBbGaBfYwSs+fVgtjCAiES+yfcZgOxWYBqJkzb CWbzCmhKrF5xkx3EFhXwktiyrx1oJgcHp4COxMojvhC7Ghklzi16zwxRLyjxY/I9Foj52hJP 3l1gBalnFlCXmDIldwIj/ywkVbOQVM1CqFrAyLyKUTK1oDg3PbfYqMAoL7Vcrzgxt7g0L10v OT93EyMwhLcd1urfwfh4SfwhRgEORiUeXo8HLFFCrIllxZW5hxglOJiVRHgD57FGCfGmJFZW pRblxxeV5qQWH2KU5mBREuflzz8WKSSQnliSmp2aWpBaBJNl4uCUamCcu/TjRY2zWam3T0uJ ZM/d/IOP6YrF3XQXQ5EHbsyTrVYy/nlqW/9NKaRi747btxSlbblcFcrrPq+qn9Mj89xOe7JW 95TqI6uF969PkN18uW0iA2dejX+ps9a8IvvyAvWGE78OrbriHCW8fEHzicgv9y2XWV/L6J5r 8+GbxKOfcw1v9x3bHmWsxFKckWioxVxUnAgAv/Bpt10CAAA= X-CMS-MailID: 20171110153140epcas2p14c261811331f0c67892cccfd5c5ab1f4 X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171109184844epcas3p2cce92ea7c58b3a517914b069013a08d0 X-RootMTR: 20171109184844epcas3p2cce92ea7c58b3a517914b069013a08d0 References: <20171109184840.GA115388@beast> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAAFVntk031295 On Thursday, November 09, 2017 10:48:40 AM Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > This also fixes the use of the "priv" variable in QERROR(), since it was > pointing to struct timer_list, not struct pxa3xx_gcu_priv. > > Cc: Bartlomiej Zolnierkiewicz > Cc: "Gustavo A. R. Silva" > Cc: Himanshu Jha > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Kees Cook > --- > If you can take this for v4.15, please do. Otherwise, I can carry it in the > timers tree in late rc1. Thanks! Thanks, I queued this for v4.15 with a trivial fix for: > #else > -static inline void pxa3xx_gcu_init_debug_timer(void) {} > +static inline void pxa3xx_gcu_init_debug_timer(struct pxa3xx_gcu_priv *) {} > #endif which caused: drivers/video/fbdev/pxa3xx-gcu.c: In function ‘pxa3xx_gcu_init_debug_timer’: drivers/video/fbdev/pxa3xx-gcu.c:534:133: error: parameter name omitted make[3]: *** [drivers/video/fbdev/pxa3xx-gcu.o] Error 1 make[3]: *** Waiting for unfinished jobs.... for the non-debug case. I also queued the original fbdev conversion patch on top of this one. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics