From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761524AbcIXIu4 (ORCPT ); Sat, 24 Sep 2016 04:50:56 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:49794 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758853AbcIXIux (ORCPT ); Sat, 24 Sep 2016 04:50:53 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: isdn@linux-pingi.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up Date: Sat, 24 Sep 2016 10:45:14 +0200 Message-ID: <1876960.mYVMvaW4Lo@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474694662-7527-1-git-send-email-baoyou.xie@linaro.org> References: <1474694662-7527-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:AURpdscMN4ipWXQsW36tjext4i5wgNwYXUy7lRXXwg5PTzMMcYS 5sZR41uYrnUe2jhtzCtG44W6v52CY+hx1m+3UALMA5wG8x0l/c9D1xorvyXuV1Ulp+wsXWT 3d4zj1i17FWWw7vv/X489RCIXHicYyiFPU6cF24qSQ/jb5CyxfHXRlEKJC6/PvHsRQkiKHW NN3pI7wNQCRjncz3CJ6gw== X-UI-Out-Filterresults: notjunk:1;V01:K0:xbB4TtIiS9Q=:D7fYhvY6xqr3jkqGiRQX9u jJnChPe4q0H+/2MA9718896hP0cIiHmjwoGnPKTR2CYKUY7L5HDdKUkYLaOAF6LVJM9qcXMkQ V8d5UxCWaEMOI9Xgz07gb/DLMcYJiSEKWqvF5UBkpsBdUy/R6B4D2MeMhari9FrmBO87rVNxi 7R5D24w222WpyulJ5A+ZYPox4N28slRjfudTcBaXnrlJlKk9FqrpnpD9zbblx4dyTNnyjWDsI RQ29lqMYoLOr7PqLwWSkbAFYKk6PIH3Q+DyIpoTFG6sqbwjnpDry2yKBEVduqa50m5ZOnWsFV rJHS6WI537Vr7I4jxbjLNMu9VAPEV+TqjJ1oJBELqJCnzXZDzqaKefHsEmdkPcPMveCnqW0OE zvyHzv21FhOVGfkZglxL8eAhkXwsbmNbqBDmgtGRmqqWSEEcCazYN/Vdmn7jFSGvKaz4pDGr8 gVLQk3++qjLV/OLVDLc1EQlNKxx/h3BdvCvzXgb7OeL+696rD33ze/FWmhwRjtikS54VSjfgH 0yJWFkQVs3V2x26yKj9C1oF626tBDqPN60lD4HyvmKCX2QSpSxbf5l4EZAoBNEBrwaoKBDSl7 6rAW3EVncADSThNIFqZJYTao9sswjwslc5UWIvfPltT/MkKbbaJeisqJePC/gkB+CXmJXgwkq jlUIP2tKP5BM/y+eNw47+QR7HdfL9ZdvVDVJptI6L/whGJ0C23uUJ6UkbCxz5HVMNFbfFyrsj 1MpUvmWg8FIFgxdc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 24, 2016 1:24:22 PM CEST Baoyou Xie wrote: > } > > -extern int open_hscxstate(struct IsdnCardState *cs, struct BCState *bcs); > extern void modehscx(struct BCState *bcs, int mode, int bc); > extern void hscx_l2l1(struct PStack *st, int pr, void *arg); > The change makes sense, but I would remove the other two declarations as well, as extern declarations don't belong into .c files. As far as I can tell, modehscx() already has a declaration in hscx.h, while hscx_l2l1() doesn't, and the declaration here should be moved as well. > diff --git a/drivers/isdn/hisax/hscx.h b/drivers/isdn/hisax/hscx.h > index 1148b4b..fa7bf16 100644 > --- a/drivers/isdn/hisax/hscx.h > +++ b/drivers/isdn/hisax/hscx.h > @@ -39,3 +39,4 @@ extern void modehscx(struct BCState *bcs, int mode, int bc); > extern void clear_pending_hscx_ints(struct IsdnCardState *cs); > extern void inithscx(struct IsdnCardState *cs); > extern void inithscxisac(struct IsdnCardState *cs, int part); > +int open_hscxstate(struct IsdnCardState *cs, struct BCState *bcs); For consistency, I would add 'extern' here. We normally leave that out, but I think if there are lots of declarations in a header file that all have it, it's better if they are all the same. Arnd