From: Florian Fainelli <f.fainelli@gmail.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, singhabhinav9051571833@gmail.com
Subject: Re: [PATCH] Remove extra unlock for the mutex
Date: Wed, 11 Oct 2023 08:47:03 -0700 [thread overview]
Message-ID: <187ea1dc-4c7d-4dee-9dfc-15f121320d0b@gmail.com> (raw)
In-Reply-To: <20231011002814.77527-1-kuniyu@amazon.com>
On 10/10/2023 5:28 PM, Kuniyuki Iwashima wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 10 Oct 2023 15:51:13 -0700
>> On 10/10/23 15:46, Abhinav Singh wrote:
>>> There is a double unlock on mutex. This can cause undefined behaviour.
>>
>> Where is the double unlock of head->lock (which is a spinlock and not a
>> mutex, btw)?
>
> Maybe head is just confused with the preceding head2 as the two are
> the same type of struct. They are pointers of different hash tables
> though.
Suspecting that much as well, though wanted to read it from the submitter.
--
Florian
next prev parent reply other threads:[~2023-10-11 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 22:46 [PATCH] Remove extra unlock for the mutex Abhinav Singh
2023-10-10 22:51 ` Florian Fainelli
2023-10-11 0:28 ` Kuniyuki Iwashima
2023-10-11 15:47 ` Florian Fainelli [this message]
2023-10-11 6:30 ` Greg KH
2023-10-11 15:49 ` Abhinav Singh
2023-10-11 17:43 ` Eric Dumazet
2023-10-11 19:07 ` Abhinav Singh
2023-10-16 14:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=187ea1dc-4c7d-4dee-9dfc-15f121320d0b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=singhabhinav9051571833@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox