From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240AbdCTRTZ (ORCPT ); Mon, 20 Mar 2017 13:19:25 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:52928 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104AbdCTRTX (ORCPT ); Mon, 20 Mar 2017 13:19:23 -0400 X-AuditID: b6c32a2e-f79d66d0000012ad-a6-58d00f17394d From: Bartlomiej Zolnierkiewicz To: Dmitry Torokhov Cc: Antonino Daplas , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: i810: remove incorrect __exit markups Date: Mon, 20 Mar 2017 18:19:17 +0100 Message-id: <1880466.B5ZPIScV32@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170302013101.GA2047@dtor-ws> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsWy7bCmlq44/4UIgzktshY/u7+wWRxe9ILR 4kTfB1aLy7vmsDmweOycdZfd4/MmuQCmKC6blNSczLLUIn27BK6MA30T2Av6+CtOX17A1sDY yNvFyMkhIWAi0X99OTuELSZx4d56ti5GLg4hgaWMEus6vjNBOO1MEu3PO5lgOhpPdEFVLWeU 2Nz1iQXC+coosXX/bLAqNgEriYntqxhBbBEBfYnts3+B2cwCKRKTHsxnBrGFBTwk3szZCrab RUBVovvSZrA4r4CmxPSrz1lBbFEBL4kt+9rBZnIK6EjMXfuYBaJGUOLH5HssEDPlJfbtn8oK YetInD22jhHkIAmB72wS8z8uAhrKAeTISmw6wAzxgYtE66mljBC2sMSr41ug/peW+Lv0FlR8 OqPE9t8SEHM2M0qs2j0Bqsha4vDxi1DL+CR6fz9hgpjPK9HRJgRR4iGx7vAudoiwo8T83zog YSGBeomdJ36yTmCUn4Xkg1lIPpiF5IMFjMyrGMVSC4pz01OLTQuM9YoTc4tL89L1kvNzNzGC 04KW3g7Gfwu8DzEKcDAq8fCuuHI+Qog1say4MvcQowQHs5II7xquCxFCvCmJlVWpRfnxRaU5 qcWHGKU5WJTEeaMMJkYICaQnlqRmp6YWpBbBZJk4OKUaGItL5C5+6o97ndSS43I+ycvNwuTT Z7tdXNW+OToM/vvtHs6avYbx0L3w6QfW1zdebZr05+5u5xcfEoQbpb/kPf90lW/S1JV/BKVs 7vzflhcgJbRvuVTLgqfuxnEl29jZGxn1M85ZBE2yfx0Xz5l3gM35SnK6CeMJuQNffXZOzFp5 pO+VzKQLG5RYijMSDbWYi4oTAR5Vt0cHAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRmVeSWpSXmKPExsVy+t9jAV1x/gsRBvNnc1v87P7CZnF40QtG ixN9H1gtLu+aw+bA4rFz1l12j8+b5AKYotxsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJz U22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWcaBvAntBH3/F6csL2BoYG3m7GDk5JARM JBpPdLFB2GISF+6tB7K5OIQEljJK7N7azgLhfGWU+HhiIzNIFZuAlcTE9lWMILaIgL7E9tm/ wGxmgRSJe1uXsILYwgIeEm/mbGUHsVkEVCW6L20G6+UV0JSYfvU5WI2ogJfEln3tTCA2p4CO xNy1j1lAbCGBRkaJB7cNIOoFJX5MvscCMV9eYt/+qawQtpbE+p3HmSYwCsxCUjYLSdksJGUL GJlXMUqkFiQXFCel5xrlpZbrFSfmFpfmpesl5+duYgRHyjPpHYyHd7kfYhTgYFTi4V1x5XyE EGtiWXFl7iFGCQ5mJRHeNVwXIoR4UxIrq1KL8uOLSnNSiw8xmgI9OJFZSjQ5HxjFeSXxhibm JubGBhbmlpYmRkrivI2zn4ULCaQnlqRmp6YWpBbB9DFxcEo1MHq8FH35OSnu9N4f+hnVKmd6 ZOuKQ9s/654pZZRj+HXwcyPfvA/hIXybH/BL8bRJigqvmcD/QSvPgj8oc9ImqRCxM/cW+m1+ NJs9fvOfA7GOacJtWcnxu7c/jpPN3LTn5NVbto38LGemvVZYFrnp3KxLAsFdPowb7GSnqEvF Pp0R6vN/Z7ybpBJLcUaioRZzUXEiAMb8/xqqAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170320171919epcas5p321ce66424b81706b1e68334903acf745 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170302013109epcas3p3ae90f60d7aa8f14bb09eb5ec342cfaeb X-RootMTR: 20170302013109epcas3p3ae90f60d7aa8f14bb09eb5ec342cfaeb References: <20170302013101.GA2047@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, March 01, 2017 05:31:01 PM Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically disables sysfs bind/unbind > attributes. > > Signed-off-by: Dmitry Torokhov Patch queued for 4.12, thanks. It seems that there are still some fbdev drivers with this issue: $ git grep __exit_p drivers/video/fbdev/ drivers/video/fbdev/amifb.c: .remove = __exit_p(amifb_remove), drivers/video/fbdev/atmel_lcdfb.c: .remove = __exit_p(atmel_lcdfb_remove), drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: .remove = __exit_p(tvc_remove), drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: .remove = __exit_p(dvic_remove), drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: .remove = __exit_p(hdmic_remove), drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: .remove = __exit_p(opa362_remove), drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: .remove = __exit_p(tfp410_remove), drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c: .remove = __exit_p(tpd_remove), drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: .remove = __exit_p(panel_dpi_remove), drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: .remove = __exit_p(dsicm_remove), drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c: .remove = __exit_p(sharp_ls_remove), drivers/video/fbdev/omap2/omapfb/vrfb.c: .remove = __exit_p(vrfb_remove), (these drivers don't disable sysfs bind/unbind attributes) Could you please also take care of fixing them? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics