From: Paul Mackerras <paulus@samba.org>
To: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] perf_counter: allow and require one-page mmap on counting counters
Date: Wed, 25 Mar 2009 19:15:13 +1100 [thread overview]
Message-ID: <18889.59409.260586.87939@cargo.ozlabs.ibm.com> (raw)
Impact: bug fix
Currently the mmap code requires that the length of the mmap be at least
two pages. That is fine for sampling counters, but for counting
counters the second and subsequent pages are just wasted, since counting
counters don't generate events.
This changes the code to require that the mmap be one page in length
for counting counters, and applies the existing check to sampling
counters.
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
Ingo, please pull this from the master branch of my perfcounters.git
repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulus/perfcounters.git master
kernel/perf_counter.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index affe227..0412c7c 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -1362,8 +1362,13 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma)
vma_size = vma->vm_end - vma->vm_start;
nr_pages = (vma_size / PAGE_SIZE) - 1;
- if (nr_pages == 0 || !is_power_of_2(nr_pages))
- return -EINVAL;
+ if (counter->hw_event.record_type == PERF_RECORD_SIMPLE) {
+ if (nr_pages)
+ return -EINVAL;
+ } else {
+ if (nr_pages == 0 || !is_power_of_2(nr_pages))
+ return -EINVAL;
+ }
if (vma_size != PAGE_SIZE * (1 + nr_pages))
return -EINVAL;
--
1.5.6.3
next reply other threads:[~2009-03-25 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 8:15 Paul Mackerras [this message]
2009-03-25 8:28 ` [PATCH] perf_counter: allow and require one-page mmap on counting counters Ingo Molnar
2009-03-25 8:34 ` Peter Zijlstra
2009-03-25 8:56 ` Paul Mackerras
2009-03-25 9:03 ` Ingo Molnar
2009-03-25 9:14 ` Peter Zijlstra
2009-03-25 9:42 ` Paul Mackerras
2009-03-31 19:15 ` Peter Zijlstra
2009-04-01 2:32 ` Paul Mackerras
2009-04-01 8:13 ` Peter Zijlstra
2009-04-01 9:31 ` Paul Mackerras
2009-03-25 11:48 ` Peter Zijlstra
2009-03-25 11:52 ` Ingo Molnar
2009-03-25 12:07 ` [tip:perfcounters/core] " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18889.59409.260586.87939@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox