From: David Laight <David.Laight@ACULAB.COM>
To: 'Dan Carpenter' <dan.carpenter@oracle.com>,
Martin Kaiser <martin@kaiser.cx>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
"Michael Straube" <straube.linux@gmail.com>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: r8188eu: remove local BIT macro
Date: Mon, 21 Mar 2022 09:04:46 +0000 [thread overview]
Message-ID: <188ea71f265a4f9c968de68dc9ea6464@AcuMS.aculab.com> (raw)
In-Reply-To: <20220321081559.GF3293@kadam>
From: Dan Carpenter
> Sent: 21 March 2022 08:16
>
> This version is better, thanks!
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> What the GCC devs should have done is run their checker on real code and
> silence the common false positives. There are a few ways to do this.
> You could make ~ a special case. They already ignore truncated sign
> extension so they could equally well ignore truncation when all it's a
> 32 bits which are all set to 1. Probably the best answer is to do both.
Or start using -(BIT_VALUE + 1) instead of ~BIT_VALUE :-)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-03-21 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 18:03 [PATCH] staging: r8188eu: remove local BIT macro Martin Kaiser
2022-03-19 22:35 ` David Laight
2022-03-21 9:06 ` Dan Carpenter
2022-03-21 9:14 ` David Laight
2022-03-21 9:34 ` Martin Kaiser
2022-03-21 8:15 ` Dan Carpenter
2022-03-21 9:04 ` David Laight [this message]
2022-03-21 9:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188ea71f265a4f9c968de68dc9ea6464@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox