From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14714C433EF for ; Mon, 21 Mar 2022 09:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345656AbiCUJGQ convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2022 05:06:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235161AbiCUJGO (ORCPT ); Mon, 21 Mar 2022 05:06:14 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 87C9C13E29 for ; Mon, 21 Mar 2022 02:04:49 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-317-OFJN3kdaOLmUPbxZoKh6yA-1; Mon, 21 Mar 2022 09:04:46 +0000 X-MC-Unique: OFJN3kdaOLmUPbxZoKh6yA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Mon, 21 Mar 2022 09:04:46 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Mon, 21 Mar 2022 09:04:46 +0000 From: David Laight To: 'Dan Carpenter' , Martin Kaiser CC: Greg Kroah-Hartman , Larry Finger , Phillip Potter , "Michael Straube" , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] staging: r8188eu: remove local BIT macro Thread-Topic: [PATCH] staging: r8188eu: remove local BIT macro Thread-Index: AQHYPPvlt7lRrzeqGEaCQ6n5CUyH5azJiwtg Date: Mon, 21 Mar 2022 09:04:46 +0000 Message-ID: <188ea71f265a4f9c968de68dc9ea6464@AcuMS.aculab.com> References: <20220319180342.3143734-1-martin@kaiser.cx> <20220321081559.GF3293@kadam> In-Reply-To: <20220321081559.GF3293@kadam> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter > Sent: 21 March 2022 08:16 > > This version is better, thanks! > > Reviewed-by: Dan Carpenter > > What the GCC devs should have done is run their checker on real code and > silence the common false positives. There are a few ways to do this. > You could make ~ a special case. They already ignore truncated sign > extension so they could equally well ignore truncation when all it's a > 32 bits which are all set to 1. Probably the best answer is to do both. Or start using -(BIT_VALUE + 1) instead of ~BIT_VALUE :-) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)