From: "Xuetao Guan " <gxt@pku.edu.cn>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: 回复： Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP
Date: Wed, 1 Oct 2014 22:38:59 +0800 (CST) [thread overview]
Message-ID: <1890664630.35241.1412174339749.JavaMail.root@bj-mail03.pku.edu.cn> (raw)
In-Reply-To: <1411981207.6334.6.camel@x220>
----- Paul Bolle <pebolle@tiscali.nl> 写道：
> On Sun, 2014-09-28 at 09:49 +0800, Xuetao Guan wrote:
> > Sorry for late reply.
>
> You replied within four days. That's rather quick, actually.
>
> > I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig
> > Sure, removing it means no different for .config file.
> > I think a better way is reserving it
>
> I'm not sure I get what you're saying here: what do mean with "reserving
> it"?
I mean, it's better to keep the code unchanged.
>
> > or moving it into arch/Kconfig
>
> Without a (treewide) patch I find it hard to say whether that's worth
> the trouble. But even if that move would be done, wouldn't it include
> dropping this entry from arch/unicore32 anyway?
IMHO, this config could be removed from kernel code.
>
>
> Paul Bolle
>
prev parent reply other threads:[~2014-10-01 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 19:13 [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP Paul Bolle
2014-09-28 1:49 ` Xuetao Guan
2014-09-29 9:00 ` Paul Bolle
2014-10-01 14:38 ` Xuetao Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1890664630.35241.1412174339749.JavaMail.root@bj-mail03.pku.edu.cn \
--to=gxt@pku.edu.cn \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox