Re: [PATCH 1/5] dt-bindings: display: Document DPI color codings

Maxime Ripard
2025-03-04T10:33:46Z

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

On Tue, Mar 04, 2025 at 06:15:26PM +0800, Liu Ying wrote:
> Document DPI color codings according to MIPI Alliance Standard for
> Display Pixel Interface(DPI-2) Version 2.00(15 September 2005).
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> .../bindings/display/dpi-color-coding.yaml | 90 +++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/dpi-color-coding.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/dpi-color-coding.yaml b/Documentation/devicetree/bindings/display/dpi-color-coding.yaml
> new file mode 100644
> index 000000000000..6430d6f1ddd1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/dpi-color-coding.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/dpi-color-coding.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MIPI DPI Interface Color Coding
> +
> +maintainers:
> + - Liu Ying <victor.liu@nxp.com>
> +
> +description:
> + MIPI Alliance Standard for Display Pixel Interface(DPI-2) Version 2.00(15
> + September 2005) specifies color codings at the DPI interface.
> +
> +properties:
> + dpi-color-coding:
> + enum:
> + - 16bit-configuration1
> + - 16bit-configuration2
> + - 16bit-configuration3
> + - 18bit-configuration1
> + - 18bit-configuration2
> + - 24bit

Do we really needs strings there? It would be much better to use an int
plus a header

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]