Re: [PATCH 1/5] dt-bindings: display: Document DPI color codings

Maxime Ripard
2025-03-05T08:26:23Z

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

On Wed, Mar 05, 2025 at 08:51:35AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Mar 04, 2025 at 11:33:44AM +0100, Maxime Ripard wrote:
> > > +properties:
> > > + dpi-color-coding:
> > > + enum:
> > > + - 16bit-configuration1
> > > + - 16bit-configuration2
> > > + - 16bit-configuration3
> > > + - 18bit-configuration1
> > > + - 18bit-configuration2
> > > + - 24bit
> >
> > Do we really needs strings there? It would be much better to use an int
> > plus a header
>
> So DTS would sill have a name, just being a define? Then what is the
> benefit comparing to strings above in DTS readability?

There's no benefits and no downside when it comes to readability.

However, it's not the only criteria, and not having to manipulate
strings but instead just doing int comparison is a huge plus.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]