Re: [PATCH 4/5] drm/bridge: simple-bridge: Add DPI color encoder support

Liu Ying
2025-03-06T05:56:35Z

On 03/04/2025, Maxime Ripard wrote:
> On Tue, Mar 04, 2025 at 06:15:29PM +0800, Liu Ying wrote:
>> A DPI color encoder, as a simple display bridge, converts input DPI color
>> coding to output DPI color coding, like Adafruit Kippah DPI hat[1] which
>> converts input 18-bit pixel data to 24-bit pixel data(with 2 low padding
>> bits in every color component though). Add the DPI color encoder support
>> in the simple bridge driver.
>>
>> [1] https://learn.adafruit.com/adafruit-dpi-display-kippah-ttl-tft/downloads
>>
>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>> ---
>> drivers/gpu/drm/bridge/simple-bridge.c | 104 ++++++++++++++++++++++++-
>> 1 file changed, 102 insertions(+), 2 deletions(-)
>
> Same thing, I think it's easy enough to write a transparent bridge to
> just put it into another driver.

I chose to touch this driver just because it seems that this DPI color
encoder fits the description of simple-bridge.yaml:

-8<-
description: |
This binding supports transparent non-programmable bridges that don't
require any configuration, with a single input and a single output.
-8<-

Anyway, if you think another driver is really needed and DT maintainers
accept to document this DPI color encoder, I may try to write one.

>
> Maxime

--
Regards,
Liu Ying