From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Brajeswar Ghosh <brajeswar.linux@gmail.com>
Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie,
jrdr.linux@gmail.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, sabyasachi.linux@gmail.com
Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header
Date: Wed, 26 Dec 2018 11:40:23 +0200 [thread overview]
Message-ID: <1891132.39bZHgSTRL@avalon> (raw)
In-Reply-To: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar>
Hi Brajeswar,
Thank you for the patch.
On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> Remove drm/drm_panel.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> ---
> drivers/gpu/drm/bridge/panel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba213ef6..402b318eeeb2 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_encoder.h>
> #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>
While at it, how about sorting headers alphabetically to make sure this won't
happen again ?
With that change,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> struct panel_bridge {
> struct drm_bridge bridge;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-12-26 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 14:32 [PATCH] drm/bridge/panel: Remove duplicate header Brajeswar Ghosh
2018-12-26 9:40 ` Laurent Pinchart [this message]
2018-12-26 10:54 ` Sam Ravnborg
2019-01-30 14:37 ` Brajeswar Ghosh
2019-01-30 15:15 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891132.39bZHgSTRL@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=brajeswar.linux@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sabyasachi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox