From: Daejun Park <daejun7.park@samsung.com>
To: Avri Altman <avri.altman@wdc.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bean Huo <beanhuo@micron.com>,
Daejun Park <daejun7.park@samsung.com>
Subject: RE: [PATCH] scsi: ufshpb: Properly handle max-single-cmd
Date: Mon, 01 Nov 2021 16:22:58 +0900 [thread overview]
Message-ID: <1891546521.01635752701431.JavaMail.epsvc@epcpadp3> (raw)
In-Reply-To: <20211031123654.17719-1-avri.altman@wdc.com>
Hi Avri,
> The spec recommends that for transfer length larger than the
> max-single-cmd attribute (bMAX_ DATA_SIZE_FOR_HPB_SINGLE_CMD) it is
> possible to couple pre-reqs with the HPB-READ command. Being a
> recommendation, using pre-reqs can be perceived merely as a mean of
> optimization. A common practice was to send pre-reqs for chunks within
> some interval, and leave the READ10 untouched if larger.
>
> Anyway, now that the pre-reqs flows have been opt-out, all the commands
> are single commands. So properly handle this attribute and do not send
> HPB-READ for transfer lengths larger than max-single-cmd.
>
> Fixes: 09d9e4d04187 (scsi: ufs: ufshpb: Remove HPB2.0 flows)
>
> Signed-off-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/scsi/ufs/ufshpb.c | 29 +++++++++++++++--------------
> drivers/scsi/ufs/ufshpb.h | 1 -
> 2 files changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Daejun Park <daejun7.park@samsung.com>
prev parent reply other threads:[~2021-11-01 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211031123708epcas2p16645db36a077acf3bd6c0138e50fedc8@epcms2p7>
2021-10-31 12:36 ` [PATCH] scsi: ufshpb: Properly handle max-single-cmd Avri Altman
2021-11-01 7:22 ` Daejun Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891546521.01635752701431.JavaMail.epsvc@epcpadp3 \
--to=daejun7.park@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox