[PATCH] scsi: ufs: Fix incorrect bit assignment for temperature notifications

[PATCH] scsi: ufs: Fix incorrect bit assignment for temperature notifications

[Keoseong Park]

According to the UFS specification, the bit positions for
`UFS_DEV_HIGH_TEMP_NOTIF` and `UFS_DEV_LOW_TEMP_NOTIF` were incorrectly
assigned. This patch corrects the bit assignment to align with the
specification.

If this issue is not fixed, devices that support both high and low
temperature notifications may function correctly, but devices that
support only one of them may fail to trigger the corresponding
exception event.

Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification support")
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
 include/ufs/ufs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
index d335bff1a310..8a24ed59ec46 100644
--- a/include/ufs/ufs.h
+++ b/include/ufs/ufs.h
@@ -385,8 +385,8 @@ enum {
 
 /* Possible values for dExtendedUFSFeaturesSupport */
 enum {
-	UFS_DEV_LOW_TEMP_NOTIF		= BIT(4),
-	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(5),
+	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
+	UFS_DEV_LOW_TEMP_NOTIF		= BIT(5),
 	UFS_DEV_EXT_TEMP_NOTIF		= BIT(6),
 	UFS_DEV_HPB_SUPPORT		= BIT(7),
 	UFS_DEV_WRITE_BOOSTER_SUP	= BIT(8),
-- 
2.25.1

RE: [PATCH] scsi: ufs: Fix incorrect bit assignment for temperature notifications

[Avri Altman]

+ Bao

> According to the UFS specification, the bit positions for
> `UFS_DEV_HIGH_TEMP_NOTIF` and `UFS_DEV_LOW_TEMP_NOTIF` were
> incorrectly assigned. This patch corrects the bit assignment to align with the
> specification.
> 
> If this issue is not fixed, devices that support both high and low temperature
> notifications may function correctly, but devices that support only one of
> them may fail to trigger the corresponding exception event.
> 
> Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification
> support")
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Already noticed by Bao D. Nguyen - see https://www.spinics.net/lists/linux-scsi/msg202162.html

Thanks,
Avri

> ---
>  include/ufs/ufs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
> d335bff1a310..8a24ed59ec46 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -385,8 +385,8 @@ enum {
> 
>  /* Possible values for dExtendedUFSFeaturesSupport */  enum {
> -	UFS_DEV_LOW_TEMP_NOTIF		= BIT(4),
> -	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(5),
> +	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
> +	UFS_DEV_LOW_TEMP_NOTIF		= BIT(5),
>  	UFS_DEV_EXT_TEMP_NOTIF		= BIT(6),
>  	UFS_DEV_HPB_SUPPORT		= BIT(7),
>  	UFS_DEV_WRITE_BOOSTER_SUP	= BIT(8),
> --
> 2.25.1
> 
> 

RE:(2) [PATCH] scsi: ufs: Fix incorrect bit assignment for temperature notifications

[Keoseong Park]

> + Bao
>
>> According to the UFS specification, the bit positions for
>> `UFS_DEV_HIGH_TEMP_NOTIF` and `UFS_DEV_LOW_TEMP_NOTIF` were
>> incorrectly assigned. This patch corrects the bit assignment to align with the
>> specification.
>> 
>> If this issue is not fixed, devices that support both high and low temperature
>> notifications may function correctly, but devices that support only one of
>> them may fail to trigger the corresponding exception event.
>> 
>> Fixes: e88e2d32200a ("scsi: ufs: core: Probe for temperature notification
>> support")
>> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
> Already noticed by Bao D. Nguyen - see https://protect2.fireeye.com/v1/url?k=81dbf2a5-e050e79f-81da79ea-74fe4860008a-0424961c73a03c70&q=1&e=fcfc99c7-cb2b-4f68-8ef4-e2760c685fec&u=https%3A%2F%2Fwww.spinics.net%2Flists%2Flinux-scsi%2Fmsg202162.html
>
> Thanks,
> Avri
>

Hi Avri,

Thank you for the update. I wasn’t aware that Bao D. Nguyen’s patch had already been applied.  
I appreciate the heads-up, and I’ll make sure to check the latest patches more carefully next time.  

Best Regards,
Keoseong

>> ---
>>  include/ufs/ufs.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
>> d335bff1a310..8a24ed59ec46 100644
>> --- a/include/ufs/ufs.h
>> +++ b/include/ufs/ufs.h
>> @@ -385,8 +385,8 @@ enum {
>> 
>>  /* Possible values for dExtendedUFSFeaturesSupport */  enum {
>> -	UFS_DEV_LOW_TEMP_NOTIF		= BIT(4),
>> -	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(5),
>> +	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
>> +	UFS_DEV_LOW_TEMP_NOTIF		= BIT(5),
>>  	UFS_DEV_EXT_TEMP_NOTIF		= BIT(6),
>>  	UFS_DEV_HPB_SUPPORT		= BIT(7),
>>  	UFS_DEV_WRITE_BOOSTER_SUP	= BIT(8),
>> --
>> 2.25.1
>> 
>> 
>