From: Paul Mackerras <paulus@samba.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Robert Richter <robert.richter@amd.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: round-robining per-cpu counters
Date: Tue, 5 May 2009 13:58:42 +1000 [thread overview]
Message-ID: <18943.47474.963294.862139@drongo.ozlabs.ibm.com> (raw)
It used to be, and as far as I can see still is, the case that per-cpu
counters take priority over per-task counters by virtue of being
scheduled in first. That is, if you have N hardware counters and >= N
per-cpu counters, then no per-task counters will ever get scheduled
onto the PMU.
That being the case, I don't see what the point of having the
perf_reserved_percpu variable is. It doesn't do anything except set
cpuctx->max_pertask, which isn't actually used anywhere. In any case
with the current counter scheduling system there's no need to
"reserve" hardware counters for use by per-cpu counters since any new
per-cpu counters will just bump existing per-task counters off - if
not immediately then the next time that perf_counter_task_tick gets
called.
What was the intended meaning of perf_reserved_percpu? I presume it
was that there would always be that many hardware counters available
for per-cpu counters regardless of how many per-task counters there
are. But that doesn't answer the complementary question - how many
hardware counters can we rely on being available for per-task
counters? At the moment the answer is 0, but I don't think that is a
good answer.
Does anyone have any good ideas about what the scheduling policy
should be?
Paul.
next reply other threads:[~2009-05-05 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 3:58 Paul Mackerras [this message]
2009-05-05 6:40 ` round-robining per-cpu counters Ingo Molnar
2009-05-05 11:57 ` Paul Mackerras
2009-05-05 13:49 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18943.47474.963294.862139@drongo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox