Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

James Bottomley
2016-08-02T15:01:39Z

On Tue, 2016-08-02 at 18:39 +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access
> permission. As we know, these numeric value for access permission
> have had the corresponding macro, and that using macro can improve
> the robustness and readability of the code, thus, I suggest replacing
> the numeric parameter with the macro.

Please stop ... can't you see that sending out over a thousand emails
with a single change in each is basically spam, especially for those of
us who got our INBOXes filled by virtue of being on the direct cc. You
don't need the thousand emails to achieve agreement over whether we
should do this, and if we decide to do it, Linus would far rather run a
simple script over the kernel as it is in an -rc state. Could you
please begin a discussion by posting the suggestion and the script.

Thanks,

James