From: Tomas Racek <tracek@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: x86, nops settings result in kernel crash
Date: Thu, 16 Aug 2012 14:45:15 -0400 (EDT) [thread overview]
Message-ID: <1898701172.1847948.1345142715802.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120816134834.GA11974@x1.osrc.amd.com>
----- Original Message -----
> On Thu, Aug 16, 2012 at 09:35:12AM -0400, Tomas Racek wrote:
> > Hi,
> >
> > I am writing a file system test which I execute in qemu with kernel
> > compiled from latest git sources and running it causes this error:
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=45971
> >
> > It works with v3.5, so I ran git bisect which pointed me to:
> >
> > d6250a3f12edb3a86db9598ffeca3de8b4a219e9 x86, nops: Missing break
> > resulting in incorrect selection on Intel
> >
> > To be quite honest, I don't understand this stuff much but I tried
> > to do some debugging and I figured out (I hope) that the crash is
> > caused by setting ideal_nops to p6_nops (k8_nops was used before
> > the break statement was added).
>
> Maybe I overlooked it or maybe it was implied but did you try
> reverting
> the patch and rerunning your test? Does it work ok then?
>
Yes, if I remove the break statement (introduced by this commit), it works fine.
Tomas
> Thanks.
>
> --
> Regards/Gruss,
> Boris.
>
next prev parent reply other threads:[~2012-08-16 18:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1104118228.1760802.1345121009530.JavaMail.root@redhat.com>
2012-08-16 13:35 ` x86, nops settings result in kernel crash Tomas Racek
2012-08-16 13:48 ` Borislav Petkov
2012-08-16 18:45 ` Tomas Racek [this message]
2012-08-16 18:53 ` Alan Cox
2012-08-16 21:30 ` H. Peter Anvin
2012-08-17 7:42 ` Tomas Racek
2012-08-16 21:51 ` [Qemu-devel] " Anthony Liguori
2012-08-17 7:43 ` Tomas Racek
2012-08-17 8:09 ` Borislav Petkov
2012-08-20 17:13 ` Tomas Racek
2012-08-21 7:22 ` Michael Tokarev
2012-08-21 9:28 ` Tomas Racek
2012-08-22 9:54 ` Avi Kivity
2012-08-22 10:03 ` [PATCH] x86, alternative: fix p6 nops on non-modular kernels Avi Kivity
2012-08-22 10:21 ` [tip:x86/urgent] x86/alternatives: Fix " tip-bot for Avi Kivity
2012-08-22 10:33 ` [PATCH] x86, alternative: fix " Tomas Racek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1898701172.1847948.1345142715802.JavaMail.root@redhat.com \
--to=tracek@redhat.com \
--cc=alan@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).