Re: [PATCH V3] mtd: rawnand: qcom: update last code word register

Miquel Raynal
2021-01-14T16:43:39Z

Hi Manivannan,

Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote on Thu,
14 Jan 2021 22:01:54 +0530:

> On Thu, Jan 14, 2021 at 04:53:25PM +0100, Miquel Raynal wrote:
> > Hello,
> >
> > Md Sadre Alam <mdalam@codeaurora.org> wrote on Sun, 10 Jan 2021
> > 09:31:45 +0530:
> >
> > > From QPIC version 2.0 onwards new register got added to
> >
> > a
> >
> > > read last codeword. This change will update the same.
> >
> > the? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Please reword this sentence.
> >
> > > For first three code word READ_LOCATION_n register will be
> > > use.For last code word READ_LOCATION_LAST_CW_n register will be
> > > use.
> >
> > "For the first three codewords, READ_LOCATION_n registers will be used.
> > The last codeword register will be accessed through
> > READ_LOCATION_LAST_CW_n."
> >
> > Also, please specify what these registers store.
> >
> > > Signed-off-by: Md Sadre Alam <mdalam@codeaurora.org>
> >
> > Could someone please test this patch?
> >
>
> This is on my TODO list. Will get back to it once I'm back from holidays
> or sooner if I find some time in the middle.

No hurry, I believe this patch still needs a little bit of effort before
being ready for upstreaming.

Thanks,
Miquèl