Re: [PATCH v2 04/19] clk: mediatek: Add MT8188 peripheral clock support

["Garmin Chang (張家銘)" <Garmin.Chang@mediatek.com>]

On Thu, 2022-10-27 at 10:22 +0200, AngeloGioacchino Del Regno wrote:
> Il 24/10/22 11:42, Garmin.Chang ha scritto:
> > Add MT8188 peripheral clock controller which provides clock
> > gate control for ethernet/flashif/pcie/ssusb.
> > 
> > Signed-off-by: Garmin.Chang <Garmin.Chang@mediatek.com>
> 
> ..snip..
> 
> > +
> > +static const struct of_device_id of_match_clk_mt8188_peri_ao[] = {
> > +	{
> > +		.compatible = "mediatek,mt8188-pericfg_ao",
> > +		.data = &peri_ao_desc,
> > +	}, {
> > +		/* sentinel */
> > +	}
> > +};
> > +
> 
> Here and for all of the other drivers that you're introducing with
> this series...
> 
> please compress this array to one line per entry, like so:
> 
> static const struct of_device_id of_match_clk_mt8188_peri_ao[] = {
> 	{ .compatible = "mediatek,mt8188-pericfg_ao", .data =
> &peri_ao_desc },
> 	{ /* sentinel */ }
> };
> 
> Regards,
> Angelo
> 

  Ok, I will modify all drivers in the next version.

> Thanks,
> Best Regards,
> Garmin