From: Markus Elfring <Markus.Elfring@web.de>
To: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com,
"James E. J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Nilesh Javali <njavali@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] scsi: qla2xxx: Use -EIO in qla_get_tmf()
Date: Fri, 19 Apr 2024 14:34:18 +0200 [thread overview]
Message-ID: <18be23bd-415e-4030-8035-d1f180cdca7a@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 19 Apr 2024 14:24:56 +0200
Add a minus sign before the error code “EIO”
so that a negative value will eventually be returned
as in another error case.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 8377624d76c9..8d93d9631ba3 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -2281,7 +2281,7 @@ int qla_get_tmf(struct tmf_arg *arg)
if (TMF_NOT_READY(fcport)) {
ql_log(ql_log_warn, vha, 0x802c,
"Unable to acquire TM resource due to disruption.\n");
- rc = EIO;
+ rc = -EIO;
break;
}
if (ha->active_tmf < MAX_ACTIVE_TMF &&
--
2.44.0
next reply other threads:[~2024-04-19 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 12:34 Markus Elfring [this message]
2024-04-19 12:45 ` [PATCH] scsi: qla2xxx: Use -EIO in qla_get_tmf() James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18be23bd-415e-4030-8035-d1f180cdca7a@web.de \
--to=markus.elfring@web.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox