The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Shirong Zhao <shxzhaosr@163.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw89: read the beacon header from the frame data
Date: Thu, 19 Nov 2026 02:29:54 +0000	[thread overview]
Message-ID: <18e2bb0a73414b528db9741eb2e2e1e3@realtek.com> (raw)
In-Reply-To: <20261118134625.801221-1-shxzhaosr@163.com>

Shirong Zhao <shxzhaosr@163.com> wrote:
> rtw89_fw_h2c_update_beacon() and rtw89_fw_h2c_update_beacon_be()
> cast the sk_buff pointer itself to struct ieee80211_hdr to compute the
> TIM offset:
> 
>         hdr = (struct ieee80211_hdr *)skb_beacon;
> 
> The 802.11 header lives in the frame data returned by
> ieee80211_beacon_get_tim(), not at the start of struct sk_buff, so the
> cast reads sk_buff metadata instead of frame_control.
> 
> For a freshly allocated skb skb->next is NULL, the value read is 0 and
> ieee80211_hdrlen() happens to return the same 24 bytes as a real beacon
> header, which masks the bug.  As soon as the skb is on a list the
> computed header length is garbage and the Group IE offset passed to the
> firmware is wrong.
> 
> Point hdr at skb_beacon->data instead.

This is key point, so I'd rephrase subject and commit message as:

subject: wifi: rtw89: read the beacon header from the skb data

message:
Point hdr at skb_beacon->data instead of skb_beacon pointer itself, to
get correct header length for TIM offset for firmware.

Fortunately, original (wrong) header fc is 0x0000, so header length is
recognized as 24 bytes, which is almost the same as AP mode application.

> 
> Found by code inspection; not observed at runtime.

I tested with real hardware.

Tested-by: Ping-Ke Shih <pkshih@realtek.com>

Fixes: 69466b979a72 ("wifi: rtw89: use struct to fill H2C command to download beacon frame")
Fixes: a880b9283009 ("wifi: rtw89: add H2C command to download beacon frame for WiFi 7 chips")

> Signed-off-by: Shirong Zhao <shxzhaosr@163.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>




  reply	other threads:[~2026-11-19  2:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  5:46 [PATCH] wifi: rtw89: read the beacon header from the frame data Shirong Zhao
2026-11-19  2:29 ` Ping-Ke Shih [this message]
2026-11-19  5:06 ` [PATCH v2] wifi: rtw89: read the beacon header from the skb data Shirong Zhao
2026-11-19  5:40   ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18e2bb0a73414b528db9741eb2e2e1e3@realtek.com \
    --to=pkshih@realtek.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=shxzhaosr@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox