From: David Rientjes <rientjes@google.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Christoph Lameter <cl@linux.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Pekka Enberg <penberg@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, Oliver Glitta <glittao@gmail.com>,
Marco Elver <elver@google.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Imran Khan <imran.f.khan@oracle.com>
Subject: Re: [PATCH v3 2/6] mm/slub: move struct track init out of set_track()
Date: Tue, 5 Apr 2022 14:40:07 -0700 (PDT) [thread overview]
Message-ID: <18ede94f-818a-d4f2-14e7-d73fdcd78eb5@google.com> (raw)
In-Reply-To: <20220404164112.18372-3-vbabka@suse.cz>
On Mon, 4 Apr 2022, Vlastimil Babka wrote:
> set_track() either zeroes out the struct track or fills it, depending on
> the addr parameter. This is unnecessary as there's only one place that
> calls it for the initialization - init_tracking(). We can simply do the
> zeroing there, with a single memset() that covers both TRACK_ALLOC and
> TRACK_FREE as they are adjacent.
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-and-tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2022-04-06 2:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 16:41 [PATCH v3 0/6] SLUB debugfs improvements based on stackdepot Vlastimil Babka
2022-04-04 16:41 ` [PATCH v3 1/6] lib/stackdepot: allow requesting early initialization dynamically Vlastimil Babka
2022-04-05 21:40 ` David Rientjes
2022-04-06 8:55 ` Vlastimil Babka
2022-04-06 12:21 ` Mike Rapoport
2022-04-04 16:41 ` [PATCH v3 2/6] mm/slub: move struct track init out of set_track() Vlastimil Babka
2022-04-05 21:40 ` David Rientjes [this message]
2022-04-04 16:41 ` [PATCH v3 3/6] mm/slub: use stackdepot to save stack trace in objects Vlastimil Babka
2022-04-05 21:40 ` David Rientjes
2022-04-06 9:03 ` Vlastimil Babka
2022-04-04 16:41 ` [PATCH v3 4/6] mm/slub: distinguish and print stack traces in debugfs files Vlastimil Babka
2022-04-05 21:40 ` David Rientjes
2022-04-06 9:09 ` Vlastimil Babka
2022-04-04 16:41 ` [PATCH v3 5/6] mm/slub: sort debugfs output by frequency of stack traces Vlastimil Babka
2022-04-05 21:40 ` David Rientjes
2022-04-04 16:41 ` [PATCH v3 6/6] slab, documentation: add description of debugfs files for SLUB caches Vlastimil Babka
2022-04-05 21:40 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18ede94f-818a-d4f2-14e7-d73fdcd78eb5@google.com \
--to=rientjes@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=elver@google.com \
--cc=glittao@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=imran.f.khan@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@lists.linux.dev \
--cc=penberg@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=rppt@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox