From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 436D3147C9B; Thu, 9 Oct 2025 02:56:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759978571; cv=none; b=RJtaxEgTTRA/8vD7+UnprM/cmEw+2k+vTicMSv3H3Mgx5v9bR8e8r9u1rpO1gzWGMt9ztpywyzgHX2XchWVB/XkWdhqMG2n9UXiDykDCra1rC+4LeQTv6HlAbY6UbKdmczjRhNIWq8qOWyarGASf+SkbigUIQu1fS+uohmHvstY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759978571; c=relaxed/simple; bh=/L9DrTEALOgY5Wmjtt3i0oB/Xl3MAwLmrrfkO95rfn0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dun0jzySlSHs2LXZY8IOfIcvWwkVptT/1OHOo/flSS5dRoOrZgvSFinl4+qOP9j6tYgixHXbw0SGE8HUnBvXZAZKSnT+52CEvRu99jNzNn8tYgnhsX7+IkmVM13gZ+SHVDc6FAgFb3wSSoppsWGS82UmSEonwGIl5lfaCoLd+2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jve+KSKh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jve+KSKh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AAD6C4CEE7; Thu, 9 Oct 2025 02:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759978569; bh=/L9DrTEALOgY5Wmjtt3i0oB/Xl3MAwLmrrfkO95rfn0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jve+KSKhnLyY8l1YhGNfNC6WkwT2LTBJ+4Ps99EVMXx1yJN634wBc1TCJjjzyulYG YLlhSNZtGoVxOCeIebBMDqaVJ2OSSc6JZ1Hl3Ah4ut/r0gV0PZjese4/rzOoQ0HNsr BNYN6vaklz7xw7wYP13rLJkJXr5sIsqyZDjoFUV0b0Uc72Cs70KZqUJ7vSbqiiJGe7 FxN7iczebyfD4I676v/oa/Ia4mNoq1EDBjljhjHTIrhABS0/ajXYiUu6orOPPhmYwE Q3NkRwqvRQeziqh3D8KEXahZHZrPZ0l7DM4K9z0kq9cYXr3J7plFShOm8pmiCrNahM Jl1Tif4FM6D3A== Message-ID: <18eebc8a-4965-4d92-8199-429144500431@kernel.org> Date: Thu, 9 Oct 2025 11:55:58 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node To: Vikash Garodia , Bryan O'Donoghue , Bryan O'Donoghue , Charan Teja Kalla , Bryan O'Donoghue , Dmitry Baryshkov Cc: Konrad Dybcio , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <7b6db4fa-2f73-376d-4eb3-64c1c7e6cda3@quicinc.com> <4d87d1ca-55b2-426e-aa73-e3fd8c6fe7bd@kernel.org> <10a8ccda-4e27-4b06-9a0e-608d6ade5354@nxsw.ie> <4cb4a92d-2f20-47c7-881e-aadcc6f83aa0@kernel.org> <1516f21e-aee3-42cf-b75e-61142dc9578d@oss.qualcomm.com> <9bae595a-597e-46e6-8eb2-44424fe21db6@linaro.org> <98e6acf8-80d7-4894-b4ce-ce74660722ef@kernel.org> <5085c857-f6e8-4faf-b61a-a9ee562ccf06@kernel.org> <0c0b6491-1def-d055-b689-2bb99f4306df@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <0c0b6491-1def-d055-b689-2bb99f4306df@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/10/2025 11:52, Vikash Garodia wrote: > > On 10/9/2025 6:34 AM, Krzysztof Kozlowski wrote: >> On 09/10/2025 09:55, Bryan O'Donoghue wrote: >>> On 09/10/2025 01:47, Krzysztof Kozlowski wrote: >>>>> Maybe it would be possible to also use an inferred FUNCTION_ID somehow >>>>> though TBH I think that's a work-around. >>>> Three months ago I gave you the answer for that - it is inferred by >>>> index on the list. >>> >>> But at least as I understand it, you can have multiple SID entries that >>> need to map to a FUNCTION_ID which means you need to encode that >>> inferred indexing in your driver. >> >> Yes. >> >>> >>> So you can't have the iommu code just know what to do.. it has to be >>> driver specific. >> >> Yes. >> >>> >>> The iommu description for this platform basically lacks the data that >>> _should_ be there -> FUNCTION_ID. >> >> No. The index tells that already. > > Hardware1 can have 2 iommus entries for FUNCTION_ID_1, while Hardware2 can have > 3 iommus entry. It would be good to keep this info in devicetree, as it is still > hardware specific (function_id is the hardware identifier). > Defaulting the index would imply, the common device driver would need to book You don't "defaulting the index" but control the indices. All what you wrote is just irrelevant. > keep the iommus and hardware id in driver for every SOC. Any mismatch in order > in DT and driver table would result in error too. It's irrelevant. You write buggy code, you are responsible for it. > > More importantly, this need to be agreed by IOMMU maintainer to extend the > iommus property. Luckily they are not hiding... Best regards, Krzysztof