From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758180AbcGZU4X (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jul 2016 16:56:23 -0400
Received: from mout.kundenserver.de ([212.227.126.135]:56600 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753616AbcGZU4W (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jul 2016 16:56:22 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
        Dong Aisheng <aisheng.dong@nxp.com>,
        Haibo Chen <haibo.chen@freescale.com>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: avoid unused function warnings
Date: Tue, 26 Jul 2016 22:56:07 +0200
Message-ID: <19008164.GYnbEcydYS@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAPDyKFoZs8DRuj2Hu_rY1iV4wKMrn6VHYeGLKmkYrMW1hfhniA@mail.gmail.com>
References: <20160726123246.879426-1-arnd@arndb.de> <CAPDyKFoZs8DRuj2Hu_rY1iV4wKMrn6VHYeGLKmkYrMW1hfhniA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:GVG0a5siVvpQ6yrfz8ig/cSITqqRodcQrY4h+y3ijq3wayJmIMn
 mKGFmwaz3YV1Zs6seqy099oEtEDRmFfqIOR3AB3tB7EazQ54L2wii2drvSb4PHjpaCsK78a
 6IDxinSf2eHwDLbop0dXHaZVsVDgV3orhEiS723kJPvpoXzCXCPfvlGzjJlIZUFDVCc6aQa
 JhXpGRfOCxUjlqV3AcTgg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:SLBFZZ5GtMU=:u+OQEfoD3whOkw6KPqQd7q
 97kUBtax51s9F9JpVi5fMbdW3t50/rm+2G7XjA86EPIdCMqDg8PwxcndhnxT31KiuipRckOjn
 Bz+OIVj088cnvs143E5mKHpehMFq4YfCcxsGQx157oVcHXMlmtMvEhhB/gJVr4bFlxy2u9WLz
 ti8qX+fHuWBM2fgc7CK/OD1D0ysuXY8s8XXJh/08VhPjf3Ks+hX+ja1UdLM2lCv4LZrcEkBqy
 megyOdv1l3uw4Y2ALF9Daw279khm2X2pCIhyhKdRc2Cca6tzQ1y6DLc5qZhgVajdTHFxuEQME
 88qYm1a8a0SVWBJr6r07vWBc9xuplF4mg/DU200is01awl/lGIJY0tPWNpw97uCZOt0KnErkl
 3slfolyAMtR5n1EDtfETz5pQXPSlRUB4f1Z7AA/PfANkmGxZ/qBDMazvDdQwHadCBHV6MR0uU
 UNAUhHwz7x9bV3PFT4FsS7tUq9ILKaeLmebZLRVuEry02PDQxxulBR3sCFf2oOvN5ItR4PK29
 PqtXXfA3TCyDtS5WwTKkJ3Q11IKTtt0UlusVddiIOmgY32+OpzaHIB+85bB8CXOmfNXDGPtOd
 DlPCx+7wAk4bvO/e05KnRAFWAJ1sND56teWld3x/B94y0JtZfoqxnC1ohFHt7sPwjzQ1y/8U5
 O2aSInb87vz2R+X7mMTz2WWTFVZh9aAyXzsb0LTqFNici6NqjtLxA4Cf6y/9MZ9dRUiXnu0EG
 A+L+AWLpT0YUbass
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, July 26, 2016 10:18:53 PM CEST Ulf Hansson wrote:
> > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> > index 2bb326bbc34a..593e34053c4b 100644
> > --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> > @@ -1293,13 +1293,12 @@ static int sdhci_esdhc_imx_remove(struct platform_device *pdev)
> >         return 0;
> >  }
> >
> > -#ifdef CONFIG_PM
> > -static int sdhci_esdhc_suspend(struct device *dev)
> > +static int __maybe_unused sdhci_esdhc_suspend(struct device *dev)
> 
> Instead of using __maybe_unused, I prefer to change above "#ifdef
> CONFIG_PMf" to "#ifdef CONFIG_PM_SLEEP".
> I do realize that the runtime PM callbacks still requires #ifdef
> CONFIG_PM, so yes that's requires an extra "ifdef".
> 
> Sure, it's more a matter of taste (and micro optimizations).

I was hoping that we could eventually do a mass-conversion to
__maybe_unused, as everybody seems to get the #ifdef wrong.

Any specific reason for your preference?

	Arnd