From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C516AC04EB9 for ; Thu, 6 Dec 2018 12:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D3B420878 for ; Thu, 6 Dec 2018 12:53:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D3B420878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729654AbeLFMxL (ORCPT ); Thu, 6 Dec 2018 07:53:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35406 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728482AbeLFMxK (ORCPT ); Thu, 6 Dec 2018 07:53:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83CF8309B6D4; Thu, 6 Dec 2018 12:53:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70676100190E; Thu, 6 Dec 2018 12:53:10 +0000 (UTC) Received: from zmail25.collab.prod.int.phx2.redhat.com (zmail25.collab.prod.int.phx2.redhat.com [10.5.83.31]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3F3E63F953; Thu, 6 Dec 2018 12:53:10 +0000 (UTC) Date: Thu, 6 Dec 2018 07:53:10 -0500 (EST) From: Frediano Ziglio To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, David Airlie , David Airlie , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" Message-ID: <1902655248.48590444.1544100790071.JavaMail.zimbra@redhat.com> In-Reply-To: <20181206114217.vog4fgae73us437u@sirius.home.kraxel.org> References: <20181206103352.20587-1-kraxel@redhat.com> <207905511.48580418.1544093965441.JavaMail.zimbra@redhat.com> <20181206114217.vog4fgae73us437u@sirius.home.kraxel.org> Subject: Re: [Spice-devel] [PATCH] drm/qxl: use qxl_num_crtc directly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.33.32.16, 10.4.195.7] Thread-Topic: drm/qxl: use qxl_num_crtc directly Thread-Index: z2mygEaMZ4w6+s4MjbtqY1/SY+m5aQ== X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 06 Dec 2018 12:53:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Thu, Dec 06, 2018 at 05:59:25AM -0500, Frediano Ziglio wrote: > > > > > > Just use qxl_num_crtc directly everywhere instead of using > > > qdev->monitors_config->max_allowed. Drops pointless indirection > > > and also is less confusing. > > > > > > > To me is MORE confusing, why comparing number of something with > > another number? Previously code was comparing number of monitors > > with number of monitors, not number of CRTs with number of > > monitors. > > Yes, spice/qxl and drm/kms use slightly different terminology. > > drm crtc == qxl monitor. > drm framebuffer == qxl surface. > > You need to know that anyway when looking at the qxl ksm code. We > have function names like qxl_crtc_update_monitors_config(). I fail > to see why that is a problem ... > > cheers, > Gerd > > I don't see any problem too but you are explaining to me why your rationale "and also is less confusing" does not stand. Frediano