From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbbIRKPJ (ORCPT ); Fri, 18 Sep 2015 06:15:09 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:65415 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753160AbbIRKOx (ORCPT ); Fri, 18 Sep 2015 06:14:53 -0400 From: Arnd Bergmann To: Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, y2038@lists.linaro.org, Mauro Carvalho Chehab , linux-api@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer Date: Fri, 18 Sep 2015 12:14:41 +0200 Message-ID: <1904442.5N0pINVFVn@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <55FBDE3E.4070608@xs4all.nl> References: <1442524780-781677-1-git-send-email-arnd@arndb.de> <2032750.MT8vj0PRkR@wuerfel> <55FBDE3E.4070608@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ryX9zZ/UeUOwnLu+iJL9AsH8LCZhLfmo742Sdpcx0wzdtiXKZhx TTNI9UEVcAT0Z+vhK+7xSegNIAWwmzUuoBHg++DsCM4asP/A1IAuAJfyzApl5keDyOasOJF +rH+C90rNYrVvkK2ViAcI58UeqYvIQfgwp/U64i7Xxd+NQdnFWvVUXg8tSY5aab4UFVg+Be DvvX1BFfF1pjy4E4yrQMQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:gXTV/uljclc=:mrz0JF2LYW7/lRhKSI7s28 umLAU+TQe/V5G3y3Qi/+Z63tSQ7jCkvRp1jhvvrm/0d4hNgbt8wKWFsk8ndcfxMuB3XpRdK9i bswzcQ8C6w1ul8kdo+q1b4IUyoOdv+gs91PAiXA+znTD2E47JY2dFYk4vkr1qr+U0w9nNdgeN OM7Q1E8S2eY6pndJco9t5rY0qRtoK+QylUwW8NwAJuF2aXqj4BQ8+7+ejEFE+uzUtPdbZzNqO K8sDDZKJVUQ9izWJ7PFr87CZ0xYrMoIGymBk+p2fJsd8hhA9PGfMZ0k3xxJaJ2VFCTduTTJDp My1SG7AY20rl8L9payaRCXZli8j8wpvXmN9EF3xvqBEg7nIphXrUnGeaTBv+qxB/mmztY0b3W CYyXS1tL4DfFa+ORBYLnj61d0g37Q27tzb2M9Z23rk5qS5p2UbyWCvdRvlAUUju7UleiZcuqk fg7yEv+ajQNG03QGoBZpTBYamA/SjF35e8poN1pVeHTwJ6UC9oajBvuynRV5e1Qfe3b/nqTI1 mmfpudlFNiNG4JGXykmCAEDPy69eFrQXsjzNNo53x2foTIn1lKOGLAxXrdtkVIi0LLqTVrcCv v1JBKqTZxzuZt1q3DlfOLJgzpIV5KwZ0EKmYsvhifSRm3JuUzzUVSHt3qQxok92r8DWssYcv1 Ptj4tVbZFtdanuh4EClTd9hZoFuUHthQWUbezJJEm2JxanzCQ1WY4r5Dz7i3KDCyIABrBbX9X BlLpORk16fUvqcQb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 18 September 2015 11:49:50 Hans Verkuil wrote: > *If* the conversion takes place only in v4l2-ioctl.c, then it makes sense > have these structs + ioctls moved to v4l2-ioctl.h. Ok. > I noticed that v4l2-compat-ioctl32.c wasn't changed. Is that right? I have > unfortunately no time to double-check that, but it surprised me. Yes, I pointed that out in the cover letter as something that is still left to be done. If we end up taking the current approach (plus the change to the location of the conversion), the compat code would basically be duplicated. Alternatively, the video_usercopy() function could just be changed to handle both 32-bit formats directly (including conversion of the multiplane array) and then we can remove that compat handler for all eight ioctls. Arnd