Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Magnus,

Thank you for the patch.

On Thursday 14 November 2013 07:59:36 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Set the ->irq_enable() and ->irq_disable() methods to NULL
> to enable lazy disable of interrupts.

Is that just for optimization purpose, or is there another reason ?

> Also extend the code to set IRQCHIP_MASK_ON_SUSPEND which tells the core
> that only IRQs marked as wakeups need to stay enabled during Suspend-to-RAM.

Shouldn't this be split to a separate patch ?

> Tested on the Lager board with GPIO-keys and Suspend-to-RAM.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  drivers/gpio/gpio-rcar.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- 0001/drivers/gpio/gpio-rcar.c
> +++ work/drivers/gpio/gpio-rcar.c	2013-11-13 19:26:26.000000000 +0900
> @@ -368,10 +368,9 @@ static int gpio_rcar_probe(struct platfo
>  	irq_chip->name = name;
>  	irq_chip->irq_mask = gpio_rcar_irq_disable;
>  	irq_chip->irq_unmask = gpio_rcar_irq_enable;
> -	irq_chip->irq_enable = gpio_rcar_irq_enable;
> -	irq_chip->irq_disable = gpio_rcar_irq_disable;
>  	irq_chip->irq_set_type = gpio_rcar_irq_set_type;
>  	irq_chip->flags	= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_SET_TYPE_MASKED;
> +	irq_chip->flags	|= IRQCHIP_MASK_ON_SUSPEND;

You can write it as

        irq_chip->flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_SET_TYPE_MASKED
                        | IRQCHIP_MASK_ON_SUSPEND;

>  	p->irq_domain = irq_domain_add_simple(pdev->dev.of_node,
>  					      p->config.number_of_pins,
-- 
Regards,

Laurent Pinchart