public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-api <linux-api@vger.kernel.org>
Subject: rseq system call incompletely wired up in microblaze
Date: Sun, 14 Oct 2018 12:46:58 -0400 (EDT)	[thread overview]
Message-ID: <1913468383.3666.1539535618042.JavaMail.zimbra@efficios.com> (raw)

Hi Michal,

I notice the following commit went into 4.18:

commit 54b0a2011dfcd2e3fe2c28062694fbbe3eb377a3
Author: Michal Simek <michal.simek@xilinx.com>
Date:   Thu Jun 14 08:24:39 2018 +0200

    microblaze: Add new syscalls io_pgetevents and rseq
    
    Wire up new syscalls io_pgetevents and rseq.
    
    Signed-off-by: Michal Simek <michal.simek@xilinx.com>

It adds the rseq system call to the microblaze syscall list, but
does not add the required hooks in the architecture code, nor does
it select HAVE_RSEQ. So effectively, even though sys_rseq is reserved
on microblaze, it currently always returns ENOSYS.

Is your intent to simply reserve the system call number, or to
also get rseq to work on microblaze ?

A good example of the architecture changes required to
wire up rseq can be found here:

commit 9d6d99e3ac8ccfd0945edb3c83cd912838775056
Author: Heiko Carstens <heiko.carstens@de.ibm.com>
Date:   Sat Jun 30 10:54:15 2018 +0200

    s390: wire up rseq system call
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

Also, please make sure the tools/testing/selftests/rseq/ tests
pass before pushing a commit enabling it for your architecture.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

             reply	other threads:[~2018-10-14 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-14 16:46 Mathieu Desnoyers [this message]
2018-10-15  7:37 ` rseq system call incompletely wired up in microblaze Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1913468383.3666.1539535618042.JavaMail.zimbra@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=boqun.feng@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox