From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753009AbeAZJqF (ORCPT ); Fri, 26 Jan 2018 04:46:05 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:53651 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752970AbeAZJqB (ORCPT ); Fri, 26 Jan 2018 04:46:01 -0500 X-Google-Smtp-Source: AH8x225rdN6GUq5sRmmUjubW4ZM/X9SoJvxuHmsLSdNX/4VRFShg1oOJzIkKfVwg3Agm5U7OASMKIg== From: Marco Martin To: linux-kernel@vger.kernel.org Cc: mjg59@srcf.ucam.org, pali.rohar@gmail.com, dvhart@infradead.org, andy@infradead.org, bhush94@gmail.com, platform-driver-x86@vger.kernel.org, mario.limonciello@dell.com, Mario Limonciello Subject: Re: [PATCH v4] Support intel-vbtn based tablet mode switch Date: Fri, 26 Jan 2018 10:45:55 +0100 Message-ID: <1914818.Wtl4XKE3JN@phobos> In-Reply-To: <1516720704-19831-1-git-send-email-notmart@gmail.com> References: <1516720704-19831-1-git-send-email-notmart@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w0Q9k9XJ003327 On martedě 23 gennaio 2018 16:18:24 CET Marco Martin wrote: > Some laptops such as Dell Inspiron 7000 series have the > tablet mode switch implemented in Intel ACPI, > the events to enter and exit the tablet mode are 0xCC and 0xCD > > CC: platform-driver-x86@vger.kernel.org > CC: Matthew Garrett > CC: "Pali Rohár" > CC: Darren Hart > CC: Mario Limonciello > CC: Andy Shevchenko > > Signed-off-by: Marco Martin > --- > drivers/platform/x86/intel-vbtn.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/platform/x86/intel-vbtn.c > b/drivers/platform/x86/intel-vbtn.c index 58c5ff3..64b4b34 100644 > --- a/drivers/platform/x86/intel-vbtn.c > +++ b/drivers/platform/x86/intel-vbtn.c > @@ -26,6 +26,9 @@ > #include > #include > > +/* When NOT in tablet mode, VBDS has the flag 0x40 */ > +#define TABLET_MODE_FLAG 0x40 > + > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("AceLan Kao"); > > @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = { > { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key release */ > { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key press */ > { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */ > + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode in */ > + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode out */ > { KE_END }, > }; > > @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event, > void *context) > > static int intel_vbtn_probe(struct platform_device *device) > { > + struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL }; > acpi_handle handle = ACPI_HANDLE(&device->dev); > struct intel_vbtn_priv *priv; > acpi_status status; > @@ -110,6 +116,21 @@ static int intel_vbtn_probe(struct platform_device > *device) return err; > } > > + status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output); > + /* VGBS being present and returning something means > + * we have a tablet mode switch > + */ > + if (ACPI_SUCCESS(status)) { > + union acpi_object *obj = vgbs_output.pointer; > + > + if (obj && obj->type == ACPI_TYPE_INTEGER) { > + input_set_capability(priv->input_dev, EV_SW, SW_TABLET_MODE); > + input_report_switch(priv->input_dev, > + SW_TABLET_MODE, > + !(obj->integer.value & TABLET_MODE_FLAG)); > + } > + } > + > status = acpi_install_notify_handler(handle, > ACPI_DEVICE_NOTIFY, > notify_handler, Is there still something to change in this version of the patch? -- Marco Martin