Re: [PATCH] dmaengine: pl330: use subsys_initcall

Krzysztof Kozłowski
2014-10-17T09:44:18Z

On 17.10.2014 02:48, Ray Jui wrote:
> As part of subsystem that many slave drivers depend on, it's more
> appropriate for the pl330 DMA driver to be initialized at
> subsys_initcall than device_initcall
>
> Signed-off-by: Ray Jui <rjui@broadcom.com>
> ---
> drivers/dma/pl330.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)

For our setup this was not needed but anyway works fine.
Tested on Trats2 (Exynos4412) and Gear2 (Exynos3250).

Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index d5149aa..abb4cae 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2811,7 +2811,17 @@ static struct amba_driver pl330_driver = {
> .remove = pl330_remove,
> };
>
> -module_amba_driver(pl330_driver);
> +static int __init pl330_init(void)
> +{
> + return amba_driver_register(&pl330_driver);
> +}
> +subsys_initcall(pl330_init);
> +
> +static void __exit pl330_exit(void)
> +{
> + amba_driver_unregister(&pl330_driver);
> +}
> +module_exit(pl330_exit);
>
> MODULE_AUTHOR("Jaswinder Singh <jassi.brar@samsung.com>");
> MODULE_DESCRIPTION("API Driver for PL330 DMAC");
>