Re: [PATCH v4 0/4] Add pinctrl support to Broadcom Cygnus SoC

Dmitry Torokhov
2015-02-25T19:30:04Z

On Tue, Feb 03, 2015 at 06:09:57PM -0800, Ray Jui wrote:
> This patchset contains the initial pinctrl (IOMUX) support for the Broadcom
> Cygnus SoC. The Cygnus IOMUX controller supports group based mux configuration
> and allows certain pins to be muxed to GPIO function individually
>
> Changes from v3:
> - Fix the driver to have more proper use of "const" in various places
> - Other minor improvements
>
> Changes from v2:
> - Consolidate all Broadcom pinctrl drivers into drivers/pinctrl/bcm/*
> - Change the Cygnus IOMUX driver to use standard Linux pinctrl subnode
> properties such as "function" and "groups" for pinmux configuration, instead
> of non-standard properties such as "brcm,function" and "brcm,group"
> - Use real function names like "spi0", "lcd", "key", and etc. instead of HW
> specific mux names like "alt1", "alt2", "alt3", and etc.
> - Add suffix "grp" to all group names
> - Add support to allow individual pins to be muxed to GPIO function through
> subsystem callbacks "gpio_request_enable" and "gpio_disable_free", and get rid
> of all GPIO groups
> - Other minor improvements in the driver
>
> Changes from v1:
> - Fix a typo in device tree binding document

FWIW I tested this series on BCM958305K SVK.

Tested-by: Dmitry Torokhov <dtor@chromium.org>

Thanks.

--
Dmitry