From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751587AbbFYHYL (ORCPT ); Thu, 25 Jun 2015 03:24:11 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:45699 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbbFYHYE convert rfc822-to-8bit (ORCPT ); Thu, 25 Jun 2015 03:24:04 -0400 Date: Thu, 25 Jun 2015 03:24:01 -0400 (EDT) From: Xu Wang To: Konstantin Khlebnikov Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <1919950089.30883798.1435217041129.JavaMail.zimbra@redhat.com> In-Reply-To: <558AD301.4070302@yandex-team.ru> References: <558AD301.4070302@yandex-team.ru> Subject: Re: [overlayfs] lockdep splat after mounting overlayfs over overlayfs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.66.12.175] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF34 (Linux)/8.0.6_GA_5922) Thread-Topic: lockdep splat after mounting overlayfs over overlayfs Thread-Index: qikUfzTZJsBwtQKV4ZW7KDJGWodIUw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I've accidentally mounted one overlayfs over another and got obvious > warning from lockdep: i_mutex lockdep classes are per-fs-type. > > # mount -t overlay overlay 1 -o > upperdir=1_upper,workdir=1_work,lowerdir=1_lower > # mount -t overlay overlay 2 -o upperdir=2_upper,workdir=2_work,lowerdir=1 > # ls 2 This reporting is positive, we are not in deadlock situation actually. The "2" dir of overlayfs will call iterate_dir->"1" dir of overlayfs->iterate_dir, and the nest iterate_dir happened on the same file system, so the warning came out. We'd better make the lower and upper in different fs instance, and this warning will disappear. And this lockdep warning happened when the nest iterate_dir call of same fs(I mean the same super block). The function check_deadlock in lockdep.c will report the nest lock of same process. If we make the 2_upper and 2_work in a different fs, no warning comes out. Thanks, -- George Wang 王旭 Kernel Quantity Engineer Red Hat Software (Beijing) Co.,Ltd IRC:xuw Tel:+86-010-62608041 Phone:15901231579 9/F, Tower C, Raycom