From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754767AbaFIMHk (ORCPT ); Mon, 9 Jun 2014 08:07:40 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:33024 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037AbaFIMHh (ORCPT ); Mon, 9 Jun 2014 08:07:37 -0400 From: Laurent Pinchart To: "Sathish Kumar Balasubramaniam -ERS, HCL Tech" Cc: Simon Horman , Magnus Damm , Paul Mundt , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3.14.6 1/1] pinctrl/sh-pfc: fix pfc-r8a7790 pin mux data for IPSR5 bug Date: Mon, 09 Jun 2014 14:08:09 +0200 Message-ID: <19212082.k9WjBDNGR8@avalon> User-Agent: KMail/4.11.5 (Linux/3.12.20-gentoo; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5D833673AB94D9489A7F7F73E9E611C814AD9363@chn-hclt-mbs08.HCLT.CORP.HCL.IN> References: <5D833673AB94D9489A7F7F73E9E611C814AD9363@chn-hclt-mbs08.HCLT.CORP.HCL.IN> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sathish, Thank you for the patch. This has already been fixed in v3.15-rc4 by commit 34ce57e9df7d14b52c7613bb2c190e411ca99186 ("sh-pfc: r8a7790: Fix definition of IPSR5"). On Sunday 08 June 2014 19:15:08 Sathish Kumar Balasubramaniam -ERS, HCL Tech wrote: > From: Sathish Kumar Balasubramaniam > > This patch fixes a bug in the list of peripheral functions for the IPSR5 pin > mux configuration of the PFC (Pin Function Controller) of the Renesas R-Car > H2 SoC (R8A7790). There should be exactly 8 values listed for the IP5_23_21 > peripheral function which is using 3 bits. But there are 9 values present > in the list. > > This bug unexpectedly increases the internal position variable by 1 which is > used by the PFC framework to identify the peripheral function. Due to this > bug, peripheral function configuration from IP5_20_18 to IP5_2_0 may not > work properly. > > This issue can be easily reproduced by setting the FN_I2C1_SDA ( IP5_9_6 [4] > ) which has the function value of 9 but the actual function value is set as > 10 due to this bug. > > ---------------------------------------------------------------------------- > --- --- linux-3.14.6/drivers/pinctrl/sh-pfc/pfc-r8a7790.c.original > 2014-06-08 22:03:44.681669692 +0530 +++ > linux-3.14.6/drivers/pinctrl/sh-pfc/pfc-r8a7790.c 2014-06-08 > 22:02:10.361673511 +0530 @@ -4624,7 +4624,7 @@ static const struct > pinmux_cfg_reg pinmu > /* IP5_23_21 [3] */ > FN_WE1_N, FN_IERX, FN_CAN1_RX, FN_VI1_G4, > FN_VI1_G4_B, FN_VI2_R6, FN_SCIFA0_CTS_N_B, > - FN_IERX_C, 0, > + FN_IERX_C, > /* IP5_20_18 [3] */ > FN_WE0_N, FN_IECLK, FN_CAN_CLK, > FN_VI2_VSYNC_N, FN_SCIFA0_TXD_B, FN_VI2_VSYNC_N_B, 0, 0, > > > Signed-off-by: Sathish Kumar Balasubramaniam The SoB line should be before the patch content, not after. Beside, it seems that tabs have been converted to spaces. Please use git format-patch to generate patch files, and git send-email to send them. -- Regards, Laurent Pinchart