From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932086AbaJ2VZw (ORCPT ); Wed, 29 Oct 2014 17:25:52 -0400 Received: from gloria.sntech.de ([95.129.55.99]:51162 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755312AbaJ2VZv (ORCPT ); Wed, 29 Oct 2014 17:25:51 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Doug Anderson Cc: Linus Walleij , Chris Zhong , Sonny Rao , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] pinctrl: rockchip: Set wake_enabled Date: Wed, 29 Oct 2014 22:29:01 +0100 Message-ID: <1922514.nxgPA75ufi@diego> User-Agent: KMail/4.12.4 (Linux/3.13-1-amd64; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1413913655-22351-1-git-send-email-dianders@chromium.org> References: <1413913655-22351-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 21. Oktober 2014, 10:47:32 schrieb Doug Anderson: > The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup > the .wake_enabled member. That means that we can never actually use a > pin for wakeup. When "irq_set_irq_wake()" tries to call through it > will always get a failure from set_irq_wake_real() and will then set > wake_depth to 0. Assuming you can resume you'll later get an error > message about "Unbalanced IRQ x wake disable". > > Signed-off-by: Doug Anderson > Tested-by: Chris Zhong I've added all 4 patches to a v3.19-pinctrl/next branch. As I'm still looking at the suspend pinctrl changes I'll wait for this before I send this to LinusW. Heiko