public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eunbong Song <eunb.song@samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "chanho.min@lge.com" <chanho.min@lge.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: Re: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned
Date: Tue, 22 Jul 2014 03:15:31 +0000 (GMT)	[thread overview]
Message-ID: <19235674.212171405998930057.JavaMail.weblogic@epml13> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 868 bytes --]


> So it's never worked?
Yes, it's always failed to mount. 
> Did you test on a little endian machine after making this change?
Unfortunately, i don't have little endian machine. So i couldn't test that.

Additionaly, when lz4 compress calls lz4_compressctx() function and uses LZ4_WRITE_LITTLEENDIAN_16() macro.
And When lz4 decompress  calls lz4_uncompress_unknownoutputsize function and 
uses LZ4_READ_LITTLEENDIAN_16 macro.
There is endian mismatch in big endian machine as i metioned before. when compress lz4 write big endian bytes order
and when decompress lz4 reads little endian bytes order. 
So i means we should make there is no endian mismatch between compress and decompress operation.

Thanks. ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

                 reply	other threads:[~2014-07-22  3:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19235674.212171405998930057.JavaMail.weblogic@epml13 \
    --to=eunb.song@samsung.com \
    --cc=chanho.min@lge.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox