From: David Howells <dhowells@redhat.com>
To: kjhall@us.ibm.com, Serge Hallyn <serge.hallyn@canonical.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
tpmdd-devel@lists.sourceforge.net
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@linux-nfs.org,
linux-crypto@vger.kernel.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
James Morris <jmorris@namei.org>,
David Safford <safford@watson.ibm.com>,
Rajiv Andrade <srajiv@linux.vnet.ibm.com>
Subject: Re: [PATCH v1.5 3/5] key: add tpm_send command
Date: Tue, 30 Nov 2010 14:32:00 +0000 [thread overview]
Message-ID: <19268.1291127520@redhat.com> (raw)
In-Reply-To: <20101124023238.GA26540@tiny>
Serge Hallyn <serge.hallyn@canonical.com> wrote:
> > +int tpm_send(u32 chip_num, void *cmd, size_t buflen)
>
> Hate to nit-pick, but any particular reason you're not following the
> rest of the file and using 'struct tpm_cmd_t *cmd' here?
Ummm... Something else I've just noticed...
static ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf,
size_t bufsiz)
would suggest that buf is read-only, but tpm_transit() keeps casting it away,
and especially, casts it away before passing it to chip->vendor.recv()...
This would seem to indicate a logic error somewhere.
Certainly, tpm_atml_recv() modifies the buffer it is given to...
I suspect the argument and reply buffer pointers should be passed separately.
David
next prev parent reply other threads:[~2010-11-30 14:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 22:50 [PATCH v1.5 0/5] keys: trusted and encrypted keys Mimi Zohar
2010-11-23 22:50 ` [PATCH v1.5 2/5] tpm: add module_put wrapper Mimi Zohar
2010-11-24 2:19 ` Serge Hallyn
2010-11-23 22:50 ` [PATCH v1.5 4/5] keys: add new trusted key-type Mimi Zohar
2010-12-01 17:48 ` David Howells
2010-12-01 21:18 ` David Safford
2010-11-23 23:43 ` [PATCH v1.5 1/5] lib: hex2bin converts ascii hexadecimal string to binary Mimi Zohar
2010-11-23 23:54 ` [PATCH v1.5 3/5] key: add tpm_send command Mimi Zohar
2010-11-24 2:32 ` Serge Hallyn
2010-11-24 12:46 ` David Safford
2010-11-24 14:59 ` Serge Hallyn
2010-11-24 16:31 ` David Safford
2010-11-30 14:32 ` David Howells [this message]
2010-11-30 15:22 ` David Safford
2010-11-24 16:21 ` [PATCH v1.5 5/5] keys: add new key-type encrypted Mimi Zohar
2010-11-28 21:56 ` [PATCH v1.5 0/5] keys: trusted and encrypted keys James Morris
[not found] ` <1290556535.2604.16.camel@localhost.localdomain>
2010-12-03 13:42 ` [PATCH v1.5 5/5] keys: add new key-type encrypted David Howells
2010-12-07 22:48 ` Mimi Zohar
2010-12-08 10:54 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19268.1291127520@redhat.com \
--to=dhowells@redhat.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=kjhall@us.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=safford@watson.ibm.com \
--cc=serge.hallyn@canonical.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox